[Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:

[Florian Schlichting]

Hi Ryan,

On Mon, Nov 12, 2018 at 08:18:07AM -0800, Ryan Tandy wrote:
> As I understand, you are already using the proposed patch (re-adding
> slapi-dev) in your own builds? If you're confident the built package works,
> you are welcome to NMU (or team-upload :-)) the addition.

yes I am building and using the slapi-dev package, and I'm confident
that "it works". It is quite trivial really, consisting only of a single
ASCII file copied verbatim from the openldap source package, and a
symlink. Quoting from the build log:

    slapi-dev_2.4.44+dfsg-5+deb9u2_amd64.deb
    ----------------------------------------

     new debian package, version 2.0.
     size 86504 bytes: control archive=639 bytes.
         539 bytes,    14 lines      control              
         278 bytes,     4 lines      md5sums              
     Package: slapi-dev
     Source: openldap
     Version: 2.4.44+dfsg-5+deb9u2
     Architecture: amd64
     Maintainer: Debian OpenLDAP Maintainers <pkg-openldap-devel at lists.alioth.debian.org>
     Installed-Size: 138
     Depends: slapd (= 2.4.44+dfsg-5+deb9u2)
     Section: libdevel
     Priority: optional
     Homepage: http://www.openldap.org/
     Description: OpenLDAP SLAPI plugin interface development headers
      This package allows development of plugins for the OpenLDAP slapd server
      using the SLAPI interface. It includes the headers and libraries needed
      to build such plugins.

    drwxr-xr-x root/root         0 2018-05-23 04:25 ./
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/include/
    -rw-r--r-- root/root     38351 2018-05-23 04:25 ./usr/include/slapi-plugin.h
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/lib/
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/lib/x86_64-linux-gnu/
    lrwxrwxrwx root/root         0 2018-05-23 04:25 ./usr/lib/x86_64-linux-gnu/libslapi.so -> libslapi-2.4.so.2.10.7
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/share/
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/share/doc/
    drwxr-xr-x root/root         0 2018-05-23 04:25 ./usr/share/doc/slapi-dev/
    -rw-r--r-- root/root     46965 2018-05-23 04:25 ./usr/share/doc/slapi-dev/changelog.Debian.gz
    -rw-r--r-- root/root     23853 2016-02-05 23:57 ./usr/share/doc/slapi-dev/changelog.gz
    -rw-r--r-- root/root     20216 2018-05-23 04:25 ./usr/share/doc/slapi-dev/copyright


(and yes, the plugin that we build with this header builds successfully,
and works - but that's beyond the scope of openldap packaging, IMHO)

> The things I would want do before uploading myself are:
> 
> - figure out what the "discussion with ftp-master" referenced in the
> 2.4.7-2 changelog was about and determine whether further follow-up is
> needed;

I think this refers to FTP masters pushing back against "trivial"
packages that only contain a few small files, where they felt the burden
on the ftpmaster and mirror infrastructure was disproportionate compared
to the benefit users might enjoy by not needing to install certain
packages. I'm not sure how big an issue this was a decade ago, but I
don't think it plays a role nowadays.

Building a new binary package does send the upload to NEW though, so I
don't think this is something to do in an NMU (and btw I'm not the
person who wrote our plugin and won't be of much help beyond packaging
questions)

> - check for file collisions with other packages (389-ds uses slapi, I'm  not
> sure whether public headers/libs are installed); and

$ apt-file search slapi-plugin.h
389-ds-base-dev: /usr/include/dirsrv/slapi-plugin.h
slapi-dev: /usr/include/slapi-plugin.h

> - build and test some kind of example SLAPI module to convince myself  the
> slapi-dev package is functional.
> 
> (hmm, shouldn't the package properly be called libslapi-dev?)

Steve's changelog entry says

  * Split slapi dev support into a new libslapi-dev package, as this is
    unrelated to libldap; and drop libslapi.a since it would be insane to try
    to statically link a dynamically-loaded slapi plugin.

but then there's commit 06777b964 renaming debian/libslapi-dev.install
to debian/slapi-dev.install: "be a bit more consistent about the package
name, so it can actually find its files..." - it seems in debian/control
it was always named slapi-dev?

Florian