Bug#877512: slapd: enabled systemd integration (untested patch)

[Moritz Mühlenhoff]

Am Wed, Jun 28, 2023 at 09:49:06AM -0700 schrieb Ryan Tandy:
> On Wed, Jun 28, 2023 at 06:29:31PM +0200, Andreas Henriksson wrote:
> > I'm attaching a patch which has only been compile-tested as I don't
> > use slapd myself. It would be great if someone who uses slapd could
> > pick it up, test it and finish the remaining work.
> 
> Thanks for the patch and for doing the compile-testing. Unfortunately
> upstream's service file won't work for us as is. The remaining work includes
> (and this is the part I've been procrastinating) extracting from the init
> script the parts that determine the arguments to slapd (based on config from
> /etc/default/slapd, and I think in some cases possibly from the slapd config
> too), and turning that into a slapd launcher script that the service will
> have to invoke.

OTOH, moving to the systemd unit might also be a good opportunity to reduce
some complexity? Looking at slapd.default shipped with the current package
SLAPD_SENTINEL_FILE, SLAPD_PIDFILE and SLAPD_NO_START are all settings which
are no longer relevant with a systemd unit or can equally be achieved with
commands built-in to systemd (e.g. systemctl mask).

Then there's a handful of settings which IMHO probably very people actually modify
(SLAPD_USER, SLAPD_USER, SLAPD_CONF, SLAPD_SERVICES) and which folks wanting
to modify can always tweak with a local unit override/dropins.

The most commonly used option is probably SLAPD_OPTIONS, which could also
be read via an EnvironmentFile from /etc/default.

Cheers,
        Moritz