Bug#877512: slapd: enabled systemd integration (untested patch)

[Andreas Henriksson]

Hello,

On Wed, Jun 28, 2023 at 09:53:06AM -0700, Quanah Gibson-Mount wrote:
> 
> 
> --On Wednesday, June 28, 2023 10:49 AM -0700 Ryan Tandy <ryan at nardis.ca>
> wrote:
> 
> 
> 
> > > TODO: For unknown reason configure seems to want to use
> > > /usr/lib/systemd/system (rather than /lib/systemd/system) despite the
> > > precense of systemd.pc ... the configure script has hard-coded fallback
> > > paths...
> > 
> > Thanks for noting this, definitely sounds like something we need to look
> > into.
> 
> Feel free to file a bug upstream if you think the current configure.ac code
> needs adjustment.
[...]

It's my impression that configure.ac is missing a call to:

PKG_PROG_PKG_CONFIG(0.29)

Thus the PKG_CONFIG variable will be unset, and thus the PKG_CHECK_*
macros will just skip over and do nothing.


FWIW you do have this:
m4_ifndef([PKG_PREREQ],
        [m4_fatal([must install pkg-config 0.29 or later before running
	autoconf/autogen])])
... but that only seems to check that pkg.m4 is new enough, not that
the actual pkg-config binary/utility exists.

Adding `PKG_PROG_PKG_CONFIG(0.29)` directly after the m4_ifndef and
rebuilding gave me the expected systemdsystemunitdir=/lib/systemd/system
(as systemd.pc says on debian) rather than the hardcoded fallbacks.

Regards,
Andreas Henriksson