Bug#1065633: openldap: FTBFS on hppa - implicit declaration of function 'kadm5_s_init_with_password_ctx'

[Ryan Tandy]

The implicit declaration occurs on all arches, but it's a warning, not 
an error. For example on amd64:

smbk5pwd.c:917:23: warning: implicit declaration of function ‘kadm5_s_init_with_password_ctx’; did you mean ‘kadm5_init_with_password_ctx’? [-Wimplicit-function-declaration]
   917 |                 ret = kadm5_s_init_with_password_ctx( context,
       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |                       kadm5_init_with_password_ctx


The binNMUs succeeded on several release arches already. I'm not sure 
why hppa would be different. I see -Werror=implicit-function-declaration 
in its compiler commands, but I don't know where it's coming from.

As for the implicit declaration, I don't remember why I didn't already 
submit a patch for it... At a quick glance it looks like the prototype 
is now in the private header <kadm5/kadm5-private.h>. I don't know if 
there's a reason we can't/shouldn't include that one... The symbol may 
be private, but we're already using it regardless :)