Bug#1065633: openldap: FTBFS on hppa - implicit declaration of function 'kadm5_s_init_with_password_ctx'

[Steve Langasek]

Control: severity -1 serious

Hi Ryan,

This bug is also reproducible on the armel and armhf release archs as a
result of the time_t transition, so bumping this to serious.

On Fri, Mar 08, 2024 at 06:04:45PM -0800, Ryan Tandy wrote:
> Would you be willing to test build the attached patch on hppa? I've tested
> it on amd64 with -Werror=implicit-function-declaration appended.


> From fa0b704371762bdc479a5d8dc6a0a6df4ec3a52e Mon Sep 17 00:00:00 2001
> From: Ryan Tandy <ryan at nardis.ca>
> Date: Fri, 8 Mar 2024 17:58:15 -0800
> Subject: [PATCH] Fix implicit declaration of kadm5_s_init_with_password_ctx
> 
> ---
>  debian/patches/series                        |  1 +
>  debian/patches/smbk5pwd-implicit-declaration | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
>  create mode 100644 debian/patches/smbk5pwd-implicit-declaration
> 
> diff --git a/debian/patches/series b/debian/patches/series
> index a8d57cb99c..7381d0a06b 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -13,3 +13,4 @@ add-tlscacert-option-to-ldap-conf
>  fix-build-top-mk
>  switch-to-lt_dlopenadvise-to-get-RTLD_GLOBAL-set.diff
>  set-maintainer-name
> +smbk5pwd-implicit-declaration
> diff --git a/debian/patches/smbk5pwd-implicit-declaration b/debian/patches/smbk5pwd-implicit-declaration
> new file mode 100644
> index 0000000000..a704086286
> --- /dev/null
> +++ b/debian/patches/smbk5pwd-implicit-declaration
> @@ -0,0 +1,12 @@
> +Description: Fix implicit declaration of kadm5_s_init_with_password_ctx
> +Bug-Debian: https://bugs.debian.org/1065633
> +--- a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
> ++++ b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
> +@@ -45,6 +45,7 @@
> + #include <krb5.h>
> + #include <kadm5/admin.h>
> + #include <hdb.h>
> ++#include <kadm5/private.h>
> + 
> + #ifndef HDB_INTERFACE_VERSION
> + #define	HDB_MASTER_KEY_SET	master_key_set
> -- 
> 2.39.2

This does fix the build failure.  I was about to push such a change to the
repo and do a maintainer upload, since I've never been removed from the
uploaders field after all these years ;)  Do you want me to do this, or
would you be able to do it tonight?  Getting openldap to build is a priority
wrt rebootstrapping 32-bit archs for time_t.

BTW there's also a reproducible test failure that I'm seeing on armhf in
both Debian and Ubuntu which is new; I'm not sure if it's related to time_t,
or if it affects other archs?

>>>>> Starting test046-dds for mdb...
running defines.sh
Running slapadd to build slapd database...
Running slapindex to index slapd database...

WARNING!
Running as root!
There's a fair chance slapd will fail to start.
Check file permissions!

Starting slapd on TCP/IP port 9011...
Testing slapd searching...
Creating a dynamic entry...
ldapadd failed (255)!
../../../tests/scripts/test046-dds: 93: kill: No such process  

>>>>> test046-dds failed for mdb after 2 seconds
(exit 255)
make[4]: *** [Makefile:303: mdb-mod] Error 255


In Ubuntu we disabled the tests on armhf to not hold up the bootstrap.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-openldap-devel/attachments/20240308/fccba213/attachment-0001.sig>