[pkg-opensc-maint] Bug#846548: patch for #846548

[Luke W Faraone]

control: tag 846548 + patch

On Sat, 6 May 2017 19:07:50 +0200 Enrico Zini <enrico at enricozini.org> wrote:
> Hello,
> 
> I'm raising severity to serious since as far as I can see the package is
> currently unusable in testing without a rebuild.

Sadly not even a rebuild will fix it. The issue is that debian/rules
specifies:

  OPENSSL_VERSION := $(shell pkg-config --modversion openssl | sed
"s/[a-z]$$//")

Which, in current unstable, resolves to:
  # pkg-config --modversion openssl | sed "s/[a-z]$//"
  1.1.0

Yet, ``openssl`` tries to find engines in
``/usr/lib/x86_64-linux-gnu/engines-1.1/``:

  # openssl engine foo
  139873873437888:error:25066067:DSO support routines:dlfcn_load:could
not load the shared
library:../crypto/dso/dso_dlfcn.c:113:filename(/usr/lib/x86_64-linux-gnu/engines-1.1/foo.so):
/usr/lib/x86_64-linux-gnu/engines-1.1/foo.so: cannot open shared object
file: No such file or directory
  139873873437888:error:25070067:DSO support routines:DSO_load:could not
load the shared library:../crypto/dso/dso_lib.c:161:
  139873873437888:error:260B6084:engine routines:dynamic_load:dso not
found:../crypto/engine/eng_dyn.c:414:
  139873873437888:error:2606A074:engine routines:ENGINE_by_id:no such
engine:../crypto/engine/eng_list.c:339:id=foo

This is a change from jessie, where it looks in
``/usr/lib/x86_64-linux-gnu/openssl-1.0.0/engines/``.

Attached is a patch to fix the path to the engine directory, and moves
this library back to libssl-dev. (it isn't clear to me from changelog or
git log why the move to 1.1 was originally reverted)

  -- Luke
-------------- next part --------------
diff -Nru libp11-0.4.4/debian/changelog libp11-0.4.4/debian/changelog
--- libp11-0.4.4/debian/changelog	2017-01-28 08:13:56.000000000 +0000
+++ libp11-0.4.4/debian/changelog	2017-05-12 02:20:40.000000000 +0000
@@ -1,3 +1,11 @@
+libp11 (0.4.4-1.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Link against libssl 1.1, since `openssl` is built against it.
+  * debian/rules: Fix path to OpenSSL engine directory. (Closes: #846548)
+
+ -- Luke Faraone <lfaraone at debian.org>  Thu, 11 May 2017 19:20:40 -0700
+
 libp11 (0.4.4-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru libp11-0.4.4/debian/control libp11-0.4.4/debian/control
--- libp11-0.4.4/debian/control	2017-01-28 08:13:56.000000000 +0000
+++ libp11-0.4.4/debian/control	2017-05-12 02:20:40.000000000 +0000
@@ -6,7 +6,7 @@
 Build-Depends: debhelper (>= 10),
                libltdl3-dev,
                libp11-kit-dev,
-               libssl1.0-dev,
+               libssl-dev,
                pkg-config
 Standards-Version: 3.9.8
 Homepage: https://github.com/OpenSC/libp11
@@ -16,7 +16,7 @@
 Package: libp11-dev
 Architecture: any
 Depends: libp11-2 (= ${binary:Version}),
-         libssl1.0-dev,
+         libssl-dev,
          pkg-config,
          ${misc:Depends}
 Description: pkcs#11 convenience library - development files
diff -Nru libp11-0.4.4/debian/rules libp11-0.4.4/debian/rules
--- libp11-0.4.4/debian/rules	2017-01-28 08:13:56.000000000 +0000
+++ libp11-0.4.4/debian/rules	2017-05-12 02:20:05.000000000 +0000
@@ -2,7 +2,7 @@
 
 include /usr/share/dpkg/architecture.mk
 
-OPENSSL_VERSION := $(shell pkg-config --modversion openssl | sed "s/[a-z]$$//")
+OPENSSL_VERSION := $(shell pkg-config --modversion openssl | sed "s/[a-z]$$//" | cut -d . -f -2)
 ENGINES_DIR := /usr/lib/$(DEB_HOST_GNU_TYPE)/openssl-$(OPENSSL_VERSION)/engines
 
 %:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 829 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-opensc-maint/attachments/20170511/01c5b5df/attachment.sig>