[Pkg-openssl-changes] r141 - in openssl/trunk: debian rand

[Kurt Roeckx]

Author: kroeckx
Date: 2006-05-02 16:34:53 +0000 (Tue, 02 May 2006)
New Revision: 141

Modified:
   openssl/trunk/debian/changelog
   openssl/trunk/rand/md_rand.c
Log:
Don't add uninitialised data to the random number generator.  This stop
valgrind from giving error messages in unrelated code.  (Closes: #363516)


Modified: openssl/trunk/debian/changelog
===================================================================
--- openssl/trunk/debian/changelog	2006-05-02 16:25:19 UTC (rev 140)
+++ openssl/trunk/debian/changelog	2006-05-02 16:34:53 UTC (rev 141)
@@ -23,6 +23,9 @@
     - Make use of invoke-rc.d
   * Add comment to README.Debian that rc5, mdc2 and idea have been
     disabled (since 0.9.6b-3)  (Closes: #362754)
+  * Don't add uninitialised data to the random number generator.  This stop
+    valgrind from giving error messages in unrelated code.
+    (Closes: #363516)
 
  -- Kurt Roeckx <kurt at roeckx.be>  Thu,  6 Apr 2006 20:34:07 +0200
 

Modified: openssl/trunk/rand/md_rand.c
===================================================================
--- openssl/trunk/rand/md_rand.c	2006-05-02 16:25:19 UTC (rev 140)
+++ openssl/trunk/rand/md_rand.c	2006-05-02 16:34:53 UTC (rev 141)
@@ -271,7 +271,10 @@
 		else
 			MD_Update(&m,&(state[st_idx]),j);
 			
+/*		
+ * Don't add uninitialised data.
 		MD_Update(&m,buf,j);
+*/
 		MD_Update(&m,(unsigned char *)&(md_c[0]),sizeof(md_c));
 		MD_Final(&m,local_md);
 		md_c[1]++;
@@ -465,7 +468,10 @@
 		MD_Update(&m,local_md,MD_DIGEST_LENGTH);
 		MD_Update(&m,(unsigned char *)&(md_c[0]),sizeof(md_c));
 #ifndef PURIFY
+/*
+ * Don't add uninitialised data.
 		MD_Update(&m,buf,j); /* purify complains */
+*/
 #endif
 		k=(st_idx+MD_DIGEST_LENGTH/2)-st_num;
 		if (k > 0)