[Pkg-opt-media-team] Bug#589112: Bug#589112: cdparanoia: add an option to not suppress progress bar when stderr is redirected

[Frank Heckenbach]

Rogério Brito wrote:

> Your patch seems good. Just one minor naming thing:
>
> > --- cdparanoia-3.10.2+debian/main.c   2008-09-11 23:11:02.000000000 +0200
> > +++ cdparanoia-3.10.2+debian/main.c   2010-07-12 22:10:07.000000000 +0200
> >  "                                    stderr (for wrapper scripts)\n"
> > +"  -E --progress                   : force output of progress bar even if\n"
> > +"                                    stderr is not a terminal\n"
> (...)
> >  long callscript=0;
> > +long force_progress_bar=0;
> (...)
> >  struct option options [] = {
> >       {"stderr-progress",no_argument,NULL,'e'},
> > +     {"progress",no_argument,NULL,'E'},
> >       {"search-for-drive",no_argument,NULL,'s'},
> (...)
>
> Perhaps it would be a good thing to make a consistent choice between the
> command line option and the variable used, for the developer's sanity?
> :-)
>
> Say, something like "-E --force-progress-bar" and leaving the variable
> name the same?

Sure. (Actually I'm not attached to the precise name at all. If you
prefer some entirely different name, I'm also fine with that.)

Do you want me to send an updated patch or can you just apply it
with your suggested rename?

Regards,
Frank