[Pkg-opt-media-team] Bug#1043879: cdparanoia: Fails to build source after successful build

[Santiago Vila]

severity 1043879 normal
tags 1043879 patch
thanks

On Sun, Aug 13, 2023 at 03:17:56PM +0200, Lucas Nussbaum wrote:
> >  cdparanoia-3.10.2+debian/config.guess
> >  cdparanoia-3.10.2+debian/config.sub

Hello. This happens because of the way config.guess and config.sub are
handled by debian/rules.

Instead of overriding dh_update_autotools_config, I propose to let it
work in the normal way, but putting files called config.guess and
config.sub in place before the buils starts, as in the attached patch.

Then dh_update_autotools_config will not only replace them by the
master copies at /usr/share/misc, but also it will remember that it
needs to remove the files in the clean target, fixing this bug.

(Note: To make debian/rules shorter, it would be also possible to do

       touch config.guess config.sub

instead of copying the files from configure.guess and configure.sub,
as dh_update_autotools_config will update the files no matter what)

Thanks.
-------------- next part --------------
commit 81dda9fe77757a757d966e44f187f38c9d82b3b8
Author: Santiago Vila <sanvila at debian.org>
Date:   Mon Dec 15 19:55:00 2025 +0100

    Fix build target. Closes: #1043879.

diff --git a/debian/rules b/debian/rules
index 28bf9f2..8d80f4d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,10 +6,9 @@ export LDFLAGS += -fPIC
 %:
 	dh $@ --no-parallel
 
-override_dh_update_autotools_config:
+execute_before_dh_auto_build:
 	cp configure.guess config.guess
 	cp configure.sub config.sub
-	dh_update_autotools_config
 
 override_dh_auto_install:
 	dh_auto_install -- prefix=$(CURDIR)/debian/tmp/usr