[Pkg-owncloud-maintainers] RFS: jquery-jplayer/2.1.0-1

[Damien Raude-Morvan]

Hi Pau!

Le lundi 07 mai 2012 02:32:57, Pau Garcia i Quiles a écrit :
> jPlayer is required by version 3.2.1 of my package witty
> (http://packages.debian.org/witty) and by owncloud (
> http://owncloud.org/ , in process of packaging by Paul van Tilburg and
> Thomas Müller).

I'm interrested in sponsoring this package (ie. for owncloud), so here we go 
for some comments :

- You use tarball-in-tarball approch with a jQuery.jPlayer.2.1.0.source.zip 
into your jquery-jplayer_2.1.0.orig.tar.gz. I'm not sure this is useful for 
this simple package : you should just repack upstream to an orig.tar.{gz,bz2}. 
This is easier for code review and for applying patches.

- Jplayer.fla file seems to be useless (according to upstream [1] and to your 
debian/rules). Since this file seems to be a binary proprietary blob (and I 
don't know any tool in Debian that can edit this file) I think you should strip 
it from upstream tarball during repack.

- (optional) Maybe you should try Debian source package formats "3.0 (quilt)" 
[2] ?

- (optional) There is also improvement for debhelper handling. I think that 
you can simplify your debian/rules file [3]

That's all :)

[1] http://jplayer.org/latest/developer-guide/#jPlayer-files-source
[2] http://wiki.debian.org/Projects/DebSrc3.0
[3] http://joeyh.name/blog/entry/cdbs_killer___40__design_phase__41__/

Cheers,
-- 
Damien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-owncloud-maintainers/attachments/20120512/4c65cd39/attachment.pgp>