[Pkg-owncloud-maintainers] owncloud-client sponsoring

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I just add a look at owncloud-client, and have some remarks and
questions I’d like to see addressed before considering its sponsorship.

debian/control:
  - Typos and similar:
    + s/ app / application /
    + s/ sync / synchronize /
    + s/ syncs / synchronizes /
    + s/ your //
    + s/ ist / is /
    + s/realiably/reliably/
    + s/Documenation/Documentation/
    + s/mirall/Mirall/
    + s/ csync / CSync /
    + s/ lib / library /
  - The first line of long description being almost a copy of the short
    one is useless
  - Short description shouldn’t start with an uppercase
  - “Documentation package for mirall“ and “Localization for mirall”
     looks like bad Description, please, consider asking for help on
     debian-l10n-english at lists.debian.org
  - Version is useless in at least pkg-kde-tools (>= 0.5)
  - Is the version need in libocsync-dev (>= 0.70.7) and
    libocsync0 (>= 0.70.7)?
debian/copyright:
  - The first LGPL should be LGPL-2.1
  - The second LGPL should be LGPL-3
    + COPYING.documentation contains a CC-3, not a LGPL
    + Is that an upstream mistake, is it reported?
  - BSD should be Expat
  - The second BSD-3-clause should be, e.g. BSD-3-clause-Kitware
  - cmake/modules/GetGitRevisionDescription.* license is missing
  - LGPL_EXCEPTION.txt must be expended
  - .h and .cpp files way be “factorized” as .*
  - src/mirall has other copyright holders, at least:
    + Daniel Molkentin <danimo at owncloud.com>
    + Markus Goetz <markus at woboq.com>
    + Thomas Mueller <thomas.mueller at tmit.eu>
debian/mirall-doc.doc-base:
  - Typos and similar, on top of those already noted for debian/control:
    + s/sftp/SFTP/
    + s/smb/SMB/
debian/*.install:
  - Shouldn’t those files contain at least two items a line?
  - Are they of any use as is?
debian/patches is empty, useless, please drop it
debian/repack.sh:
  - Why the upstream tarball needs to be repack?
  - What does admin contain?
  - “Remove stuff” is really not a useful comment
  - Please consider using dfsg instead of +debian for the repack
  - Do you really need to rename it?
debian/watch:
  - Please fix the dversionmangle in debian/watch

At least qtsingleapplication is already used by kadu, what does the KDE
team think about getting qtsingleapplication and qtlockedfile available
separately?

During the build, I guess at least the following error is not expected:

> dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
> dpkg-gensymbols: warning: debian/libowncloudsync0/DEBIAN/symbols doesn't match completely debian/libowncloudsync0.symbols

Lintian also gives two pointers:

> I: owncloud-client: desktop-entry-lacks-keywords-entry usr/share/applications/owncloud.desktop
> E: libowncloudsync0: symbols-file-contains-current-version-with-debian-revision on symbol _ZN6Mirall14oCICredentialsD1Ev at Base and 1 others

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRlVz4AAoJELgqIXr9/gnydtYP/Aud5+i2WTW5leK3S/nWdT+M
+xlCnV+6I4BDPz7sDIFpDxpQQyUWJ3fWXhHiQrtcBRA5wCojEnmbSZCm3FtXl9gT
IOBAbVmKiWplcXfHoC9GTj7dX7JzNTd0U8eHWGl0pX3q8VlUURdFP3bdXG8U32u4
jRuj2vb7gAHNq33+DYkznNu5KMrYhautUOqubv3LwljYbZVWki7haw+mpQZUpiPE
bCAae+UcuZVOLst5ItizEOjv1A/IrZCPzfWpg3yqhB8zRvRlffE7iEaR0fJoQXSw
wkBnoD8YaykdMNTCijODS2fNLrBCupuRaOPLaUwTKUFXqNSWxayisznBH74HU4TH
HKlVhuUyaSAJzuLDFOC+VB4ylnTeOHNI8OS9N6LkbU2EgS/PtauxLkY0QiXV2JAU
mrIRXxHtwo6aK39q1P9pwgA/y9n/op/1eso6Syb0xoWuvxhE791oswPY1KI6tDtU
WUB7YGTm45axw3dGj/8GXps62+iIUjNSthPTiuHYfTf6RaztlqtcN+uH43x3t/ko
jkPAic6XwoKiFR2sZ0BJiqm2T+Y6PBff9JGZ9bw5Ugq7A0FCQDGraFyeBl2QYJ92
sinpjroHnHwwrLoyvkkBtaUe1o5aqS2ameFEuzFk7ETITrZSRaXEw53UReE6gqU4
MzrmlZAUv+non20jxMnU
=zfJ+
-----END PGP SIGNATURE-----