[Pkg-owncloud-maintainers] FTBS ocsync & qtkeychain

[Pino Toscano]

In data giovedì 19 settembre 2013 14:57:07, Svante Signell ha scritto:
> > Furthermore, your changes are losing the check for an empty HOME.
> 
> I don't think so, in that case getenv returns NULL

No. Things like
$ export FOO=
give an empty string as result, which is what the check was about.

> > >  #ifdef _WIN32
> > >  #include <windef.h>
> > >  #include <winbase.h>
> > > 
> > > @@ -50,6 +54,11 @@
> > > 
> > >  #define geteuid() 0
> > >  #endif
> > > 
> > > +#ifndef ENODATA
> > > +#define ENODATA EPIPE
> > > +#endif
> > 
> > This may be problematic. c_copy in src/std/c_file.c uses ENODATA as
> > errno in a couple of error situations, but since c_copy is an
> > exported symbol (although its header is not installed), users of
> > this function would need to do this ENODATA→EPIPE mapping
> > themselves too.
> 
> This is not part of my patch. Address this to upstream/debian
> maintainer directly.

I don't care whether it is yours or not, I just reviewed it since all 
the proposed changes are now discussed with pkg-owncloud people.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-owncloud-maintainers/attachments/20130919/6531e3c9/attachment.sig>