[Pkg-owncloud-maintainers] FTBS owncloud-client - Q_OS_FREEBSD not set

[Robert Millan]

On 23/10/2013 02:11, Sandro Knauß wrote:
> On the kfreebsd machine it breaks with:
> 
> /home/taffit/owncloud-client-1.4.2+dfsg/src/mirall/utility.cpp: In function 
> 'QString Mirall::Utility::platform()':
> /home/taffit/owncloud-client-1.4.2+dfsg/src/mirall/utility.cpp:156:1: error: 
> expected ';' before '}' token
>  }
>  ^
> 
> I fixed the syntax error, but actually kFreeBSD should fall into the FreeBSD 
> path :) Or am I wrong?

GNU/kFreeBSD has the same kernel as FreeBSD, and the same userland (as
in, C runtime) as GNU/Linux.

So it should fall into whatever matches what you're currently checking.

If you need to satisfy a check for kernel functionality, use
__FreeBSD_kernel__

If you need to satisfy a check for compiler / libc functionality, use
__GNUC__ and __GLIBC__

If you need something weird, like giving the whole thing a "name", you
need to check what this name is used for. If it's just cosmetic, it
doesn't matter. But if it's used to infer details about the components
of the system, then try avoiding that kind of checks entirely, or if
that's too hard use the one that will do the least damage.

-- 
Robert Millan