[Pkg-owncloud-maintainers] dompdf in OwnCloud

Adam Williamson awilliam at redhat.com
Wed Jan 1 18:59:43 UTC 2014


On Wed, 2014-01-01 at 14:52 -0400, David Prévot wrote:
> Hi Adam,
> 
> Le 31/12/2013 13:51, Adam Williamson a écrit :
> > On Tue, 2013-12-31 at 11:00 -0400, David Prévot wrote:
> >> [ Following up to the mailing list with Adam permission, please keep
> >>   him CC on reply. Keeping full context of the part I’m replying to for
> >>   people starting to follow now. ]
> >>
> >> Le 31/12/2013 03:48, Adam Williamson a écrit :
> 
> >>> […] the only path patch we have that you don't is for
> >>> Pimple, but I'm not sure if you've unbundled that (yet).
> >>
> >> Indeed we haven’t unbundled it yet (it’s really a short one IIRC)
> 
> For the record, Pimple one class with about 50 lines of code, I don’t
> believe Debian ftpmasters would be happy if we introduce it, especially
> since nothing but ownCloud seems to currently use it in Debian. If there
> is a good reason to package it, please speak up (I may volunteer to take
> care of it if needed). I believe phpass fall into the same category…

I think we just got ours as part of OC unbundling. The 'makes sense to
unbundle' line is definitely a bit blurry...I'm never quite sure where
to draw it. Gregor seems to take an "UNBUNDLE ALL THE THINGS" approach,
I lose patience when it's a couple of files that clearly have no sane
upstream distribution anyway...

I've sent that patch upstream anyway as I believe it's upstreamable:
https://github.com/owncloud/core/pull/6601

> > So, the best web 'portal' would I guess be pkgdb, though I don't really
> > use it much myself:
> > 
> > https://admin.fedoraproject.org/pkgdb/acls/name/owncloud
> 
> Thanks, it’s useful.
> 
> > http://pkgs.fedoraproject.org/cgit/owncloud.git/tree/owncloud.spec is
> > our current 'state of the art', more or less.
> 
> I’m not use to the .spec format, but it’s well enough documented to
> understand, thanks.

I think if you understand the basic concept of packaging it's not too
hard to figure out what's going on...at least it works in the other
direction, I don't really know the nuts and bolts of how .deb packaging
actually works but it's reasonably easy to find the interesting
customizations from a packages.debian.org page, I've found.

> Looks like https://github.com/owncloud/core/issues/4469 is getting
> resolved, but FYI, the mediawiki Debian package has been split to
> provide the classes independently.

Yeah, I considered that, but it seems not worth the effort if upstream's
going to stop using them. If anything we'd probably want a more
concerted effort to make js minifying consistent distro-wide, but that
sounds like a hell of a project :/

> Thanks to those file comments, I realize I overlooked (at least) the
> mediaelement stuff, on my way to have a closer look and fix that.

No probs. We found that because someone did a Fedora-wide sweep looking
for pre-built Flash and Silverlight blobs and found quite a lot - Debian
might be interested in doing the same thing, if it hasn't
already...other classic ones are TTFs and .exes, but I'd expect Debian
already has checks for those...
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net




More information about the Pkg-owncloud-maintainers mailing list