[Pkg-owncloud-maintainers] Bug#735535: autopkgtest fails

[Martin Pitt]

Package: owncloud-client
Version: 1.5.0+dfsg-4

Hello,

owncloud-client's autopkgtest currently fails [1]:

  mkdir obj-/config
  mkdir: cannot create directory ���obj-/config���: No such file or directory 

That's because debian/rules uses $DEB_HOST_GNU_TYPE without defining
it. Modern dpkg-buildpackage does that, but autopkgtest doesn't use
that and Debian policy also says that invoking debian/rules directly
should work.

After fixing that, the test fails on an invalid variable expansion:

adt-run: & ubtree0t-make-tests: [----------------------------------------
/tmp/adt-run.Le8IcK/ubtree0-build/real-tree/debian/tests/make-tests: 3: /tmp/adt-run.Le8IcK/ubtree0-build/real-tree/debian/tests/make-tests: ADTTMP: not found

After fixing that, the test fails on an unknown make target:

ubtree0t-make-tests  FAIL status: 0, stderr: make: *** No rule to make target `tests'.  Stop.

At this point I'm lost. "make test" (the usual name if you add
automatic tests to cmake) doesn't exist either, nor does "make check".
What is the intention here? Is there some way to run the upstream
tests against the installed package? Running them against the built
source tree is against autopkgtest's intention -- you wouldn't
actually verify that the installed package works.

Also, debian/tests/make-tests creates/removes the "config" directory in the
current dir (i. e. the source tree root), not in $ADTTMP.

Attached debdiff fixes above issues, but the "tests" make target issue
still needs to be fixed. It should run some smoketesting against the
installed package.

Thanks for considering,

Martin

[1] https://jenkins.qa.ubuntu.com/job/trusty-adt-owncloud-client/11/ARCH=i386,label=adt/console
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
diff -Nru owncloud-client-1.5.0+dfsg/debian/changelog owncloud-client-1.5.0+dfsg/debian/changelog
--- owncloud-client-1.5.0+dfsg/debian/changelog	2014-01-02 14:10:09.000000000 +0100
+++ owncloud-client-1.5.0+dfsg/debian/changelog	2014-01-16 11:25:23.000000000 +0100
@@ -1,3 +1,13 @@
+owncloud-client (1.5.0+dfsg-4ubuntu2) UNRELEASED; urgency=medium
+
+  * debian/rules: Define $DEB_HOST_GNU_TYPE as dh_auto_test is using it. Fixes
+    autopkgtest.
+  * debian/tests/make-tests:
+    - Fix $ADTTMP variable expansion.
+    - Fix path of temporary config directory.
+
+ -- Martin Pitt <martin.pitt at ubuntu.com>  Thu, 16 Jan 2014 10:49:37 +0100
+
 owncloud-client (1.5.0+dfsg-4ubuntu1) trusty; urgency=medium
 
   * Update libowncloudsync0.install for multi-arch location.
diff -Nru owncloud-client-1.5.0+dfsg/debian/rules owncloud-client-1.5.0+dfsg/debian/rules
--- owncloud-client-1.5.0+dfsg/debian/rules	2013-12-30 23:20:02.000000000 +0100
+++ owncloud-client-1.5.0+dfsg/debian/rules	2014-01-16 10:49:35.000000000 +0100
@@ -1,8 +1,11 @@
 #!/usr/bin/make -f
 
+DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
+
 export CSYNC_DIR=/usr/include/ocsync
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-pie
 
+
 %:
 	dh $@ --parallel --with sphinxdoc --with pkgkde_symbolshelper
 
diff -Nru owncloud-client-1.5.0+dfsg/debian/tests/make-tests owncloud-client-1.5.0+dfsg/debian/tests/make-tests
--- owncloud-client-1.5.0+dfsg/debian/tests/make-tests	2013-12-30 23:20:02.000000000 +0100
+++ owncloud-client-1.5.0+dfsg/debian/tests/make-tests	2014-01-16 11:25:19.000000000 +0100
@@ -1,4 +1,4 @@
 #! /bin/sh
-mkdir config
-XDG_CONFIG_HOME=$(ADTTMP)/config/ make tests
-rm -r config
+mkdir $ADTTMP/config
+XDG_CONFIG_HOME=$ADTTMP/config/ make tests
+rm -r $ADTTMP/config