[Pkg-parrot-devel] Parrot 3.3.0-1 package is in mentors

Sat Apr 30 13:21:27 UTC 2011

On Sat, Apr 30, 2011 at 02:47:06AM -0700, Allison Randal wrote:
> On 04/23/2011 10:12 AM, Dominique Dumont wrote:
> >Hello
> >
> >I've uploaded in mentors a new package for parrot 3.3.0:
> >
> >You can download it from:
> >
> >http://mentors.debian.net/debian/pool/main/p/parrot/
> >
> >Feedback are welcome.
> 
> Thanks, Dominique! I've reviewed your changes and Kyle's, and
> produced an integrated set of 3.3 packages. I didn't accept all your
> changes, detailed comments follow.
> 
> Both you and Kyle caught the patches that were applied upstream, so
> you're both listed with credit in the changelog (Kyle caught one you
> didn't). Same with the moved files for manpage generation.
> 
> debian/copyright: I applied the patch changing the format of the
> copyright file to DEP5, and listed you with credit. But, I changed
> the Upstream-Contact to the email address of developer's list
> instead of the URL of the Parrot Foundation.
> 
> debian/control: I applied the update to source package format "3.0
> (quilt)" and gave you credit. I kept the original package
> descriptions, and kept Conflicts instead of Breaks. I also didn't
> add you to Uploaders (you're motivated, and I'm sure you'll earn
> that right in due time, but it's not really something I'm
> comfortable granting the first time someone contributes patches to a
> package).
> 
> parrot-doc.install: I didn't install the examples/ directory, it's a
> random collection of code snippets written in Parrot and doesn't
> belong in the parrot-doc package. If the examples are installed at
> all, they should be in a separate parrot-examples package, but
> what's there isn't really worth it.
> 
> parrot.install: I understand why other Parrot core devs on IRC might
> have suggested installing all of the languages/ and library/
> directories in the parrot Debian package, but it's not right for
> Debian. If any language modules are installed, they should be
> installed as separate packages (parrot-<languagename>), not
> installed in the main parrot.install, but none of the current
> languages in the Parrot tarball are complete enough or useful enough
> to install. (Parrot languages are generally developed in their own
> source repositories, with their own release tarballs and their own
> packaging.) And the library/ directory in the source contains a lot
> of unmaintained cruft that really shouldn't be installed, which is
> why the parrot packages currently only install a select set of
> libraries.
> 
> I also didn't add parrot-prove to the package, since it's a
> less-feature-ful reimplemention of 'prove' from the perl package in
> Debian, and really only used during source builds, not package
> installs.
> 
> 
> >Note that they are some minor issues left like a png file in the wrong place,
> >or mising symbol file. I do not know yet how to fix them.
> 
> I don't get these errors in my version of the package, they may have
> been caused by the new files added in your packages.
> 
> 
> The amd64 versions of the integrated 3.3.0 packages are temporarily
> up at http://pub.lohutok.net/parrot/. I tested these packages with a
> source build of the April Rakudo Star release.

Just a few comments on the packages:

- No need to Build-Depends on quilt anymore. This fixes the
  unneeded-build-dep-on-quilt lintian P tag.

- It would be nice to have a Homepage field in debian/control, e.g.:

    Homepage: http://parrot.org

  This would fix the no-homepage-field lintian tag.

- Lintian also warns about a couple of spelling errors (reenable -> 
  re-enable). I've attached a patch that fixes them (drop it under
  debian/patches). I would also suggest to merge it upstream (I can do a 
  pull request via GitHub if needed).

- I've attached a *.symbols file for the libparrot3.3.0 package. It was
  generated using dpkg-gensymbols(1). Have a look at [0] for an explanation
  of what a symbols file is. Basically it helps dpkg-shlibdeps to
  generate more accurate dependencies on libraries given the symbols that 
  they export. This would fix the no-symbols-control-file lintian tag.

- At some point, we should also add the Vcs-* fields to debian/control 
  pointing to the git repository where the package is being maintained.

The lintian warnings can be reproduced by running "lintian -IE --pedantic"
on the binary *.changes file. Note that all the changes proposed are quite
trivial and not really urgent, so feel free to ignore them :)

I've attached a debdiff with all the proposed changes.

Cheers

[0] http://wiki.debian.org/Projects/ImprovedDpkgShlibdeps

-- 
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_fix_spelling_errors.patch
Type: text/x-diff
Size: 544 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-parrot-devel/attachments/20110430/054eb8ba/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libparrot3.3.0.symbols.gz
Type: application/octet-stream
Size: 7088 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-parrot-devel/attachments/20110430/054eb8ba/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debdiff.diff.gz
Type: application/octet-stream
Size: 8131 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-parrot-devel/attachments/20110430/054eb8ba/attachment-0001.obj>