[Pkg-pascal-devel] New bugs fixed in FPC, upload needed

[Paul Gevers]

On 17-01-14 00:23, Abou Al Montacir wrote:
> Can you please review and upload?

I didn't build yet, remarks are from code inspection.

Two minor things, can you please split
change-path-to-.mo-directories-to-fit-Debian-standar.patch into two? One
fixing the issue and one for the encoding of the German file? And please
also mention that in the changelog. (If you prefer, I can do this before
I upload, just let me know).

And the other, for this patch to be more valuable upstream:
I don't know if it is possible and/or difficult, but to make the
/usr/local/ to /usr/ change in the *.pp files more valuable upstream it
would be great if it would be sensitive to the configuration option for
${INSTALL_PREFIX} like your other changes. Please just comment if you
thought about it and found it not worth the effort (but you as upstream
might want to fix this).

[Interesting, I was going to write the following, but this intl folder
doesn't have the usual Makefile.fpc: Last thing: in the patch you modify
a Makefile, but those are removed in the clean target. Should the
relevant change not be put somewhere were it is picked up by fpmake?]

I trust you have checked or confirmed the other patch on functionality,
it is too much internals for me to check/understand.

Paul



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 551 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/cgi-bin/mailman/private/pkg-pascal-devel/attachments/20140118/b3cb0501/attachment.sig>