[Pkg-pascal-devel] New bugs fixed in FPC, upload needed

[Abou Al Montacir]

On Sat, 2014-01-18 at 08:40 +0100, Paul Gevers wrote:

> On 17-01-14 00:23, Abou Al Montacir wrote:
> > Can you please review and upload?
> 
> I didn't build yet, remarks are from code inspection.
> 
> Two minor things, can you please split
> change-path-to-.mo-directories-to-fit-Debian-standar.patch into two? One
> fixing the issue and one for the encoding of the German file? And please
> also mention that in the changelog. (If you prefer, I can do this before
> I upload, just let me know).

I've split the patch into 2 patches as suggested. This is indeed better
for maintainability.


> And the other, for this patch to be more valuable upstream:
> I don't know if it is possible and/or difficult, but to make the
> /usr/local/ to /usr/ change in the *.pp files more valuable upstream it
> would be great if it would be sensitive to the configuration option for
> ${INSTALL_PREFIX} like your other changes. Please just comment if you
> thought about it and found it not worth the effort (but you as upstream
> might want to fix this).

I think this is manageable using -d compiler switch, but I don't think
it is worth the effort.


> [Interesting, I was going to write the following, but this intl folder
> doesn't have the usual Makefile.fpc: Last thing: in the patch you modify
> a Makefile, but those are removed in the clean target. Should the
> relevant change not be put somewhere were it is picked up by fpmake?]

In the rules file we only remove auto-generated files:
find * -name Makefile.fpc -execdir 'sh' '-c' '${RM} $$(basename
{} .fpc)' ';'


> I trust you have checked or confirmed the other patch on functionality,
> it is too much internals for me to check/understand.

$makeskel --lang=de --package=foobar --input='foobar.pp'
MakeSkel - FPDoc skeleton XML description file generator
Version 2.6.2 [2014/01/20]
(c) 2000 - 2003 Areca Systems GmbH / Sebastian Guenther,
sg at freepascal.org

<?xml version="1.0" encoding="ISO-8859-1"?>
<fpdoc-descriptions>
<package name="foobar">
Error while documenting: foobar.pp
</package>
</fpdoc-descriptions>
Fertig.

$makeskel --lang=de --package=foobar --input='foobar.pp'
makeskel        makeskel-2.6.0  makeskel-2.6.2  
[mazen at karim:test]$makeskel-2.6.0 --lang=de --package=foobar
--input='foobar.pp'
MakeSkel - FPDoc skeleton XML description file generator
Version 2.6.0 [2013/04/14]
(c) 2000 - 2003 Areca Systems GmbH / Sebastian Guenther,
sg at freepascal.org
NOTE: unable to find tranlation
file /usr/local/share/locale/de/LC_MESSAGES/makeskel.mo
An unhandled exception occurred at $0807E87F :
EFOpenError : Unable to open file
"/usr/local/share/locale/de/LC_MESSAGES/dglobals.mo"
  $0807E87F
  $080992BD
  $0809E500
  $0804A00D
  $0804A644

:)!!

Cheers,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/cgi-bin/mailman/private/pkg-pascal-devel/attachments/20140120/5b9a4204/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/cgi-bin/mailman/private/pkg-pascal-devel/attachments/20140120/5b9a4204/attachment.sig>