[Pkg-pascal-devel] Bug#1105521: Bug#1105521: Bug#1105521: pasdoc: FTBFS with make --shuffle=reverse:

[Peter Blackman]

On 17/05/2025 10:39, Abou Al Montacir wrote:
> Hi Peter,
> 
> 
> On Fri, 2025-05-16 at 18:02 +0100, Peter Blackman wrote:
>> Hi Michalis,
>>
>> I agree that the bug is line 35 in the rules file
>> make -C source/component clean all
> Why do we call clean before all?
> I would expect that clean is already called before build.
>>
>> Obviously it depends on left > right execution.
>> When run in reverse, it does make all first,
>> then cleans out what it just built!!
>>
>> I prefer adding an extra line, so we have
>>
>>         ....
>>         make -C source/component clean
>>         make -C source/component all
>>         ....
>>
>> That ensures that make ... all is always run after the clean
> I would remove clean and let only all. Of course cleaning should be done 
> in the clean target.
> 
> -- 
> 
> Cheers,
> Abou Al Montacir
> 
> 

There is a circular dependency in the upstream build.

make source/component all   regenerates some .inc files.
the .inc files are needed by build-tools.
make source/component all relies on build-tools.

Premature cleaning of source/component will therefore
break the build. It is where it is, to ensure the .inc
are actually rebuilt.

Cheers,
Peter B