Bug#299606: marked as done (fix warning in do_one_loop)

Debian Bug Tracking System owner@bugs.debian.org
Sat, 26 Mar 2005 13:03:26 -0800


Your message dated Sat, 26 Mar 2005 15:50:48 -0500
with message-id <E1DFIF6-0004wO-00@newraff.debian.org>
and subject line Bug#299606: fixed in libnet-irc-perl 0.75-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Mar 2005 10:02:43 +0000
>From abi@grinser.de Tue Mar 15 02:02:43 2005
Return-path: <abi@grinser.de>
Received: from 82-133.colo24.de (schiach.de) [213.155.82.133] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DB8st-0006xc-00; Tue, 15 Mar 2005 02:02:43 -0800
Received: by schiach.de (Postfix, from userid 2002)
	id 2A55711DC6; Tue, 15 Mar 2005 11:02:36 +0100 (CET)
Date: Tue, 15 Mar 2005 11:02:36 +0100
From: Michael Ablassmeier <abi@grinser.de>
To: submit@bugs.debian.org
Subject: fix warning in do_one_loop
Message-ID: <20050315100235.GA15987@jail.schiach.de>
Reply-To: abi@grinser.de
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="BOKacYhQ+x31HxR3"
Content-Disposition: inline
User-Agent: Mutt/1.4.2.1i
X-Accept-Language: de en
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: libnet-irc-perl
Severity: minor
Tags: patch
Version: 0.75-2

hi,

do_one_loop complains about an uninitialized value[0], im not sure what
the source of this problem is. It seems like on every 2nd run, if you
call do_one_loop repeately, caller(1) wont return anything. However,
attached patch makes do_one_loop only return and test $caller if its
actually defined.

[0] 
 Use of uninitialized value in string eq at /usr/share/perl5/Net/IRC.pm line 141.

bye,
    - michael

--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="IRC.pm.diff"

--- IRC.pm	2004-04-30 20:02:51.000000000 +0200
+++ IRC.pm.fixed	2005-03-15 10:29:15.832433728 +0100
@@ -138,7 +138,7 @@
   # we don't want to bother waiting on input or running
   # scheduled events if we're just flushing the output queue
   # so we bail out here
-  return if $caller eq 'Net::IRC::flush_output_queue';
+  return if defined($caller) and $caller eq 'Net::IRC::flush_output_queue'; 
 
   # Check the queue for scheduled events to run.
   if(!$self->schedulequeue->is_empty) {

--BOKacYhQ+x31HxR3--

---------------------------------------
Received: (at 299606-close) by bugs.debian.org; 26 Mar 2005 20:54:20 +0000
>From katie@ftp-master.debian.org Sat Mar 26 12:54:20 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DFIIW-00031v-00; Sat, 26 Mar 2005 12:54:20 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DFIF6-0004wO-00; Sat, 26 Mar 2005 15:50:48 -0500
From: Gunnar Wolf <gwolf@debian.org>
To: 299606-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#299606: fixed in libnet-irc-perl 0.75-3
Message-Id: <E1DFIF6-0004wO-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 26 Mar 2005 15:50:48 -0500
Delivered-To: 299606-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: libnet-irc-perl
Source-Version: 0.75-3

We believe that the bug you reported is fixed in the latest version of
libnet-irc-perl, which is due to be installed in the Debian FTP archive:

libnet-irc-perl_0.75-3.diff.gz
  to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-3.diff.gz
libnet-irc-perl_0.75-3.dsc
  to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-3.dsc
libnet-irc-perl_0.75-3_all.deb
  to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 299606@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gunnar Wolf <gwolf@debian.org> (supplier of updated libnet-irc-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 26 Mar 2005 13:28:24 -0600
Source: libnet-irc-perl
Binary: libnet-irc-perl
Architecture: source all
Version: 0.75-3
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: Gunnar Wolf <gwolf@debian.org>
Description: 
 libnet-irc-perl - IRC (Internet Relay Chat) interface module for Perl
Closes: 299606
Changes: 
 libnet-irc-perl (0.75-3) unstable; urgency=low
 .
   * Added debian/watch file
   * Fixed uninitialized value generating a warning in do_one_loop -
     Thanks to Michael Ablassmeier for the patch. (Closes: #299606)
Files: 
 453ddf8af609d943a81fcb7a1be4f388 685 perl optional libnet-irc-perl_0.75-3.dsc
 f896266b5b8935db7de046163a391b74 3029 perl optional libnet-irc-perl_0.75-3.diff.gz
 c3a24b2e4c501c93161a283a56cf6661 69870 perl optional libnet-irc-perl_0.75-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCRbqX2A7zWou1J68RAp2yAJ0UrEzeJBVDzxFLOpI3/BlcNew2qwCfa1Wg
F8hOQSXHNuEk+j/4hub8O2U=
=oLnY
-----END PGP SIGNATURE-----