Bug#388717: 388717 is actually caused by libdbd-sqlite3-perl

[Niko Tyni]

tag 388717 patch
thanks

On Tue, Oct 10, 2006 at 09:16:23PM +0200, gregor herrmann wrote:
> 
> Maybe I'm blind but I don't find "the fix" anywhere.
> The last message in
> https://rt.cpan.org/Public/Bug/Display.html?id=21472 is "I take this
> back" (probably referring to the fix mentioned earlier), and the CVS
> doesn't show any activity at
> http://axkit.org/cgi-bin/viewcvs.cgi/DBD-SQLite/lib/DBD/

Hi,

the fix can be found in the upstream CVS repository:

http://axkit.org/cgi-bin/viewcvs.cgi/DBD-SQLite/dbdimp.c.diff?r1=1.64&r2=1.65

The patch seems to help; hopefully somebody else from the Debian Perl
Group can verify this and prepare a fixed package as I'm a bit short on
time right now.

I'm attaching the patch as well.

Cheers,
-- 
Niko Tyni	ntyni at iki.fi
-------------- next part --------------
--- DBD-SQLite/dbdimp.c	2006/09/18 18:54:05	1.64
+++ DBD-SQLite/dbdimp.c	2006/09/18 20:16:47	1.65
@@ -394,12 +394,12 @@
     
     sqlite_trace(3, "Execute returned %d cols\n", DBIc_NUM_FIELDS(imp_sth));
     if (DBIc_NUM_FIELDS(imp_sth) == 0) {
-        while ((retval = sqlite3_step(imp_sth->stmt)) != SQLITE_DONE) {
-            if (retval == SQLITE_ROW) {
+        while ((imp_sth->retval = sqlite3_step(imp_sth->stmt)) != SQLITE_DONE) {
+            if (imp_sth->retval == SQLITE_ROW) {
                 continue;
             }
             sqlite3_finalize(imp_sth->stmt);
-            sqlite_error(sth, (imp_xxh_t*)imp_sth, retval, (char*)sqlite3_errmsg(imp_dbh->db));
+            sqlite_error(sth, (imp_xxh_t*)imp_sth, imp_sth->retval, (char*)sqlite3_errmsg(imp_dbh->db));
             return -5;
         }
         /* warn("Finalize\n"); */