Bug#470090: libsoap-lite-perl: "Subroutine redefined" warnings

[gregor herrmann]

tag 470090 + confirmed
severity 470090 minor
thanks

On Sun, 09 Mar 2008 01:54:43 +0000, Adam D. Barratt wrote:

> result in a couple of warnings:
> 
> Subroutine LWP::UserAgent::redirect_ok redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 41.
> Subroutine LWP::Protocol::collect redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 59.

Right, I see them here too.

A diff on lib/SOAP/Transport/HTTP.pm against the previous version
shows:

#v+
@@ -34,9 +32,10 @@
 # hack for HTTP connection that returns Keep-Alive
 # miscommunication (?) between LWP::Protocol and LWP::Protocol::http
 # dies after timeout, but seems like we could make it work
+my $_patched = 0;
 sub patch {
+    return if $_patched;
     BEGIN { local ($^W) = 0; }
-    no warnings "redefine";
     {
         sub LWP::UserAgent::redirect_ok; *LWP::UserAgent::redirect_ok = sub {1}
     }
#v-

Turning off the warnings again should be rather simple by re-adding
the deleted line; I just don't feel very comfortable about
suppressing warnings in general ...

Other comments?

Cheers,
gregor
-- 
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  debian: the universal operating system - http://www.debian.org/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-    NP: Nick Cave & The Bad Seeds: Easy Money
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20080403/077c5da3/attachment.pgp