Bug#463773: $string || $otherstring does not do what this module thinks it does

[Joey Hess]

Package: libxml-feed-perl
Version: 0.12-1
Severity: normal

        $item->{author} || $item->{dc}{creator};

Woah unto an author named "0", who will be passed over for the creator.

        $item->{guid} || $item->{link};

"0" is a not very good, but conceivable guid.

        $feed->{rss}->channel('language') ||
        $feed->{rss}->channel->{dc}{language};

There is probably not a language named "0", but why build this assumption
into the code?

        $feed->{rss}->channel('generator') ||
	$feed->{rss}->channel->{'http://webns.net/mvcb/'}{generatorAgent};

This makes me *want* to name my feed generator "0".

        $feed->{rss}->channel('webMaster') ||
        $feed->{rss}->channel->{dc}{creator};

..

This is probably not an exhaustive list, I only looked in RSS.pm.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libxml-feed-perl depends on:
ii  libclass-errorhandler-perl 0.01-2        Base class for error handling
ii  libdatetime-format-mail-pe 0.3001-1      Convert between DateTime and RFC28
ii  libdatetime-format-w3cdtf- 0.04-2        Parse and format W3CDTF datetime s
ii  libdatetime-perl           2:0.41-1      perl DateTime - Reference implemen
ii  libfeed-find-perl          0.06-2        Syndication feed auto-discovery
ii  libhtml-parser-perl        3.56-1        A collection of modules that parse
ii  liburi-fetch-perl          0.08-1        Smart URI fetching/caching
ii  liburi-perl                1.35.dfsg.1-1 Manipulates and accesses URI strin
ii  libwww-perl                5.808-1       WWW client/server library for Perl
ii  libxml-atom-perl           0.25-2        Atom feed and API implementation
ii  libxml-rss-perl            1.31-3        Perl module for managing RSS (RDF 
ii  perl                       5.8.8-12      Larry Wall's Practical Extraction 

libxml-feed-perl recommends no packages.

-- no debconf information

-- 
see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20080203/4d5d06f7/attachment.pgp