Bug#472760: libimage-size-perl: imgsize command gives spurious warnings

[Reid Priedhorsky]

Package: libimage-size-perl
Version: 3.1.1-1
Severity: normal
Tags: patch


Dear Sir or Madam:

Invoking the "imgsize" command produces warnings which are apparently
spurious, e.g.:

10 [~/www/trips/2007-bwcaw]$ imgsize rp/img_1463.jpg
Found = in conditional, should be == at /usr/bin/imgsize line 124.
Found = in conditional, should be == at /usr/bin/imgsize line 131.
Found = in conditional, should be == at /usr/bin/imgsize line 139.
Found = in conditional, should be == at /usr/bin/imgsize line 146.

This has appeared recently.

I have included a patch which appears to fix the problem.

Thanks for your hard work on Debian!

Reid

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-k7 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages libimage-size-perl depends on:
ii  libcompress-zlib-perl         2.008-2    Perl module for creation and manip
ii  perl                          5.8.8-12   Larry Wall's Practical Extraction 

libimage-size-perl recommends no packages.

-- no debconf information
-------------- next part --------------
--- imgsize.orig	2008-03-25 23:25:19.252868420 -0500
+++ imgsize	2008-03-25 23:28:01.000000000 -0500
@@ -121,7 +121,7 @@
 {
     my ($html) = html_imgsize($_[0]);
 
-    (defined $html) ? $html : ($error = 1 and "error");
+    (defined $html) ? $html : ($error = 1) and "error";
 }
 
 sub return_attr
@@ -129,19 +129,19 @@
     my ($width, $height, $err) = imgsize($_[0]);
 
     (defined $width) ?
-        "(-width => $width, -height => $height)" : ($error = 1 and "error: $err");
+        "(-width => $width, -height => $height)" : ($error = 1) and "error: $err";
 }
 
 sub return_imgsize
 {
     my ($width, $height, $err) = imgsize($_[0]);
 
-    (defined $width) ? "$width $height" : ($error = 1 and "error: $err");
+    (defined $width) ? "$width $height" : ($error = 1) and "error: $err";
 }
 
 sub return_fmt
 {
     my ($width, $height, $err) = imgsize($_[0]);
 
-    (defined $width) ? sprintf($opt_f, $width, $height, $err) : ($error = 1 and "error: $err");
+    (defined $width) ? sprintf($opt_f, $width, $height, $err) : ($error = 1) and "error: $err";
 }