Bug#480420: dh-make-perl: wrong arch=all on Devel::FindRef and others

[gregor herrmann]

On Sat, 10 May 2008 07:38:07 +1000, Kevin Ryde wrote:

> Running
> 	dh-make-perl --build --cpan Devel::FindRef
> results in a package libdevel-findref-perl_1.2-1_all.deb, where I hoped
> that since it contains some xs it'd be "_i386.deb".

Should already be fixed in 0.43. Could you please try and report
back?
 
> I suspect in check_for_xs() the precedence of ! is higher than =~,
> 	! $File::Find::name =~ /$opts{exclude}/
> so no file is ever considered an xs.  Perhaps it could use !~ (below),
> or some parens.

Hm, this line really indeed looks ... interesting.
 
> Incidentally, nosing around it looks like the "." in ".svn" of the
> default $opts{exclude} pattern might want want to be escaped, though I
> don't suppose a file "/Zsvn/myfile.xs" ever occurs in practice.

Good catch, thanks.


I'll take a closer look at these lines tomorrow.


Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  debian gnu/linux user, admin & developer - http://www.debian.org/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-    NP: Penelope Swales: Black Carrie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20080510/3a8ec024/attachment.pgp