Bug#479580: Can't reproduce bug

[Martín Ferrari]

Hi David,

On Mon, May 19, 2008 at 2:09 PM, David Caldwell <david at porkrind.org> wrote:

> It takes a special kind of flac--I think it needs to be missing the vendor
> field to fail. According to my (very light) research that field might be
> required, so you probably can't reproduce with the standard flac tools.

Ah, I see.

> The Nine Inch Nails download that recently came out has this issue. Since it
> was Creative Commons licensed I can give you a link to my copy:
>
> http://bandwidth.porkrind.org/tmp/month/999,999.flac
>
> It's the intro and is only about 5.5MB.
>
> Even if it is a required field, missing it shouldn't make Lib::Audio::Flac
> crash...

Agreed, but I've tried both with 2.0 and 2.1 releases without getting
any segmentation fault:

$ perl -MData::Dumper -MAudio::FLAC::Header -e
'$flac=Audio::FLAC::Header->new("999,999.flac") or die $!; print
Dumper $flac->tags'
$VAR1 = {
          'COMPILATION' => '0',
          'YEAR' => '2008',
          'ARTIST' => 'Nine Inch Nails',
          'DISC' => '1',
          'ENCODER' => 'Sound Grinder 3.2.4',
          'TOTALTRACKS' => '10',
          'ALBUM' => 'The Slip',
          'TITLE' => '999,999',
          'TRACKNUMBER' => '1',
          'VENDOR' => undef,
          'COMPOSER' => 'Trent Reznor',
          'DISCC' => '1'
        };

$ perl -MData::Dumper -MAudio::FLAC::Header -e
'$flac=Audio::FLAC::Header->new("999,999.flac") or die $!; print
Dumper $flac->info'
$VAR1 = {
          'MD5CHECKSUM' => 'e24f0b3b8ee703170303e6b2187dd44d',
          'MINIMUMBLOCKSIZE' => 4608,
          'BITSPERSAMPLE' => 16,
          'SAMPLERATE' => 44100,
          'NUMCHANNELS' => 2,
          'MAXIMUMFRAMESIZE' => 10728,
          'MAXIMUMBLOCKSIZE' => 4608,
          'MINIMUMFRAMESIZE' => 27,
          'TOTALSAMPLES' => '3755527'
        };

I'm also using the same libflac version as you, so I don't understand
what could be happening here. Could you try this again, before and
after updating to the latest versions from unstable? I now have perl
5.10 so if this was fixed with that transition, I cannot test it now.

> Sorry about that, the version "david1" was the Debian version with my fix
> applied, nothing else. I sent the bug after installing my version and
> confirming that the patch really fixed the problem. The problem exists with
> version 2.0-1.

Ah, no problem then.

Thanks!

-- 
Martín Ferrari