Bug#482339: po-debconf: podebconf-report-po uses poor HELO hostname

[Nicolas François]

notfound  482339 1.0.13
found     482339 0.79-4
reassign  482339 libmail-sendmail-perl
thanks

On Wed, May 21, 2008 at 03:53:19PM -0700, rra at debian.org wrote:
> 
> podebconf-report-po, when sending mail via the local server, appears to
> use a HELO string of the unqualified local hostname.  This isn't a valid
> argument to HELO per the SMTP standard as I understand it; I believe
> HELO requires a fully-qualified domain name.  Postfix configured to
> reject non-FQDN HELOs (which is a helpful anti-spam measure that stops
> quite a bit of bogus mail) therefore rejects the mail.
> 
> The fix is probably as simple as using hostname --long instead, but I
> haven't looked at the code.

Well, I've not implemented the SMTP protocol in podebconf-report-po. I'm
using Mail::Sendmail, which according to its manpage uses Sys::Hostname,
which uses gethosname(2) and other methods which all return the hostname
(not a FQDN)

I have no way to configure the behavior of these modules, thus I'm
reassigning this bug to libmail-sendmail-perl.

On my box, I could test successfully these two commands:
	perl -e 'use Sys::Hostname; print hostname()."\n";'
It returns the hostname

	perl -e 'use Sys::Hostname::Long; print hostname_long()."\n";'
It returns the fully qualified domain name.

I would propose to add
	* a dependency on libsys-hostname-long-perl:
	* use Sys::Hostname::Long; # for use of hostname in HELO

and change:
	$localhost = hostname() || 'localhost';
to
	$localhost = hostname_long()() || hostname() || 'localhost';
(not tested)

Kind Regards,
-- 
Nekral