Bug#538115: test suite fails with perl critic complaint

[Jonathan Yu]

Hi Joey:

I finally tracked down this bug!

On Sat, Jul 25, 2009 at 11:18 AM, Joey Hess<joeyh at debian.org> wrote:
> Jonathan Yu wrote:
>> I can't reproduce this using libtest-distmanifest-perl built inside a
>> chroot. Is it possible that you have an older version? Could you
>> please repeat the build with the latest version (1.2.2)?
>
> I typoed the version; my build was on 1.2.2.
>
>> If you continue having FTBFS issues please let me know. The latest
>> version does have the perlcritic tests in B-D-I:
>> libtest-perl-critic-perl (>= 1.01), libperl-critic-perl (>= 1.098),
>
> That explains how perl critic got installed on my chroot.

As it turns out,  it's because of two things... Firstly, that I have
taint mode enabled in t/01critic.t (the -T flag to perl). Second, it's
because you had the Pod::Spell and other dependencies installed.

This explains why I wasn't able to reproduce it.

Basically, it was trying to do some sort of spell check, but had to
fork out to the environment to look around for 'aspell' and run it. In
the course of that, it was emitting this message:

Insecure $ENV{PATH} while running with -T switch at
/usr/share/perl5/Perl/Critic/Policy/Documentation/PodSpelling.pm line
221, <GEN0> line 5.

>
> I can't reproduce it in a clean squeeze chroot. Odd..
That, would be because you don't have the PodSpelling policy's
dependency chain installed inside a clean chroot.

There are two things you can do to work around this:
1. Remove the -T flag from t/01critic.t's shebang
2. Exclude the PodSpelling tests (via 01critic.rc -- I'll be doing
this for future releases)

I'll be fixing this in the upstream version and pushing a release
shortly, so I'm marking this bug as done. If you have any other
concerns or if the above workaround doesn't work (outside of your
clean chroot) then please let me know :-)

Thanks again
>
> --
> see shy jo
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iD8DBQFKayJMd8HHehbQuO8RAjChAJ9+rthuFq/6p0xq5IcpxLtOTWceSgCg7B2O
> 3ZYSwOmNbUwmP4FQ+4yAK7U=
> =vflv
> -----END PGP SIGNATURE-----
>
>