Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors

[Jonathan Yu]

Perl::Critic is an author test. Sometimes authors may write tests that
are broken and not bother to fix them, because they're run only by
authors. Likely the author saw those failures while building and chose
to ignore them for one reason or another. A fix would be to provide a
perlcriticrc file which can explicitly exclude those tests, but that's
all we can do. the problem is, really, upstream.

If the test is disabled it should build fine, and not really harm
program functionality. I'm not sure of the specifics of writing DBD
drivers, so perhaps those class names are required by the particular
driver interface.

Still, I recommend just packaging the module and skipping that test.
It would be simple to add a plan skip all to the top...

On Tue, Mar 31, 2009 at 12:04 PM, gregor herrmann <gregoa at debian.org> wrote:
> tags 521969 + confirmed
> forwarded 521969 http://rt.cpan.org/Public/Bug/Display.html?id=44704
> thanks
>
> On Mon, 30 Mar 2009 17:53:43 -0700, Daniel Schepler wrote:
>
>> Package: libdbd-pg-perl
>> Version: 2.11.7-1
>> Severity: serious
>>
>> From my pbuilder build log:
>>
>> ...
>> t/99_perlcritic.....#
>> # File: Pg.pm (line 157)
>> # Vio: Package "DBD::Pg::dr" does not start with a upper case letter
>> # Policy: NamingConventions::Capitalization
>> # Source: package DBD::Pg::dr;
>
> Thanks, the tests still fail with 2.12.0.
> I've forwarded the bug upstream and I'll turn off the Perl::Critic
> tests in debian/rules for the time being.
>
> Cheers,
> gregor
> --
>  .''`.   Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
>  : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
>  `. `'   Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
>   `-    NP: Eagles
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAknSPxcACgkQOzKYnQDzz䡵ည୒䯅ꮴ㴖Ṳ䢹慴ᦴ�
> L48AoPVh0drvqkaVbGNhsj8HgxHoujGH
> =FAni
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> pkg-perl-maintainers mailing list
> pkg-perl-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
>