Bug#528675: libnet-arp-perl: Buffer overflow in get_mac_linux()

Jonathan Yu jonathan.i.yu at gmail.com
Sun May 17 20:18:52 UTC 2009


Hi Franck:

Thanks for the patch. It looks good. However, I'm wondering why you
chose to use strncpy instead of strlcpy? If it's a portability issue,
then perhaps it would be possible to detect if strlcpy is available on
the system and fall back on strncpy otherwise?

It's probably not a big deal, but I do know that strlcpy is a bit
better on performance.

Cheers,

Jonathan

On Sun, May 17, 2009 at 1:50 PM, Franck Joncourt
<franck.mail at dthconnex.com> wrote:
> Hi,
>
> Could you check with the enclosed patch that it works fine.
>
> Thanks,
>
> --
> Franck Joncourt
> http://debian.org - http://smhteam.info/wiki/
>
> _______________________________________________
> pkg-perl-maintainers mailing list
> pkg-perl-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
>





More information about the pkg-perl-maintainers mailing list