Bug#551007: [Net-ssleay-devel] Bug#551007: please add ripemd160 digest to libnet-ssleay-perl

[Daniel Kahn Gillmor]

Hi Mike--

On 10/15/2009 06:11 PM, Mike McCauley wrote:
> Thanks for th patch.

You're welcome.

> Thinking about backwards compat, is <openssl/ripemd.h> available going back to 
> the dim history of openssl? If not it should be #ifdefed with some version 
> number (net-ssleay is expected to compile against old versions of openssl).

How far back deos the "dim history" go?  OpenSSL's changelog says:

Changes between 0.9.4 and 0.9.5  [28 Feb 2000]

    [...]
*) RIPEMD160 is operational on all platforms and is back in 'make test'.
   [Andy Polyakov]


I don't see any version checks for anything earlier than 0.9.8, but i do
see your point; it's a reasonable goal.  So I've now applied the patch
to upstream SVN, added in checks to make sure that OpenSSL is at least
0.9.5, and made the tests conditional on the presence of the digest as
well.  The revised patch is attached, and should apply cleanly to the
current svn trunk (r255).

I also updated the documentation snippets i added to indicate that
digests might or might not be available depending on the OpenSSL version.

Let me know if you have other concerns.  Thanks for the speedy responses!

	--dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-ripemd160.upstream.diff
Type: text/x-diff
Size: 6119 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20091016/661dc7e3/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 891 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20091016/661dc7e3/attachment-0001.pgp>