Bug#548935: dh-make-perl: Bad YAML-related comments

[Slaven Rezic]

Package: dh-make-perl
Version: 0.47
Severity: minor

In my copy of dh-make-perl I find the following comment in the process_meta
function around line 430:

    # YAML::LoadFile has the bad habit of dying when it cannot properly parse
    # a file - Catch it in an eval, and if it dies, return -again- just an
    # empty hashref. Oh, were it not enough: It dies, but $! is not set, so we
    # check against $@. Crap, crap, crap :-/

The first point about dying is debatable. It is not documented in the YAML
Pod, but it is quite valid for a module to do so. But the second point is not 
debatable. If eval fails, then you have always to look up in $@, never in $!.
Please check perldoc -f eval.

Regards,
    Slaven


-- System Information:
Debian Release: 5.0.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/bash

Versions of packages dh-make-perl depends on:
ii  debhelper                7.0.15          helper programs for debian/rules
ii  dpkg-dev                 1.14.25         Debian package development tools
ii  fakeroot                 1.11            Gives a fake root environment
ii  libemail-date-format-per 1.002-1         Module to generate RFC-2822-valid 
ii  libmodule-depends-perl   0.14-1          identify the dependencies of a dis
ii  libwww-mechanize-perl    1.34-2          Automate interaction with websites
ii  libyaml-perl             0.66-1          YAML Ain't Markup Language (tm)
ii  make                     3.81-5          The GNU version of the "make" util
ii  perl                     5.10.0-19lenny2 Larry Wall's Practical Extraction 
ii  perl-modules [libpod-par 5.10.0-19lenny2 Core Perl modules

Versions of packages dh-make-perl recommends:
ii  apt-file                 2.1.5           APT package searching utility -- c
ii  perl-modules [libmodule- 5.10.0-19lenny2 Core Perl modules

dh-make-perl suggests no packages.

-- no debconf information