Bug#576878: dh-make-perl: bad control file building Exporter::Renaming

[gregor herrmann]

tag 57687 + confirmed
thanks

On Thu, 08 Apr 2010 08:34:38 +1000, Kevin Ryde wrote:

> With Exporter::Renaming 1.18 from cpan and untarred, running
> 
>     dh-make-perl --requiredeps --build Exporter-Renaming-1.18

> ,----
> | Description: Allow renaming of symbols on import
> | 
> |  .
> |  This description was automagically extracted from the module by dh-make-perl.
> `----
> 
> I suppose the blank line is no good.  There was an earlier complaint
> 
>     Package does not provide a long description -  Please fill it in manually.
> 
> if that's relevant.

Yes, it is :)

I can reproduce this; the problem is in Renaming.pm:

#v+
=head1 DESCRIPTION


=head2 Overview
#v-

i.e. an empty DESCRIPTION (or a "blank line description"). If I
change thhis section to
 
#v+
=head1 DESCRIPTION

Allow Renaming of symbols on Import

=head2 Overview
#v-

dh-make-perl creates a description like:

#v+
Description: Allow renaming of symbols on import
 Allow Renaming of symbols on Import
 .
 This description was automagically extracted from the module by dh-make-perl.
#v-

and I suppose the build would succeed afterwards.


Conclusions:
* --build (i.e. not looking at the generated debian/* files before
  building) is not really a good idea :)
* dh-make-perl should handle this case a bit more gracefully (by not
  inserting blank lines in debian/control's Description).

Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Rolling Stones: You Better Move On
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20100409/5abc447b/attachment-0001.pgp>