[PATCH] Fix two uninitialized value warnings triggered with Perl 5.12.0

Tue Apr 20 07:10:09 UTC 2010

Perl 5.12.0 has new uninitialized value warnings for the various
lc* and uc* functions. These break the test suite:

 Failed test 14 in t/modules/apache_status.t at line 47
 Failed test 15 in t/modules/apache_status.t at line 47 fail #2

so short-circuit the variables to the empty string.
---
 lib/Apache2/Status.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/Apache2/Status.pm b/lib/Apache2/Status.pm
index 288531a..8bbebdb 100644
--- a/lib/Apache2/Status.pm
+++ b/lib/Apache2/Status.pm
@@ -95,8 +95,8 @@ sub install_hint {
 
 sub status_config {
     my ($r, $key) = @_;
-    return (lc($r->dir_config($key)) eq "on") ||
-        (lc($r->dir_config('StatusOptionsAll')) eq "on");
+    return (lc($r->dir_config($key) || "") eq "on") ||
+        (lc($r->dir_config('StatusOptionsAll') || "") eq "on");
 }
 
 sub menu_item {
-- 
1.7.0.4


--huq684BweRXVnRxX--



------------=_1271847966-6066-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 578481-close) by bugs.debian.org; 21 Apr 2010 11:03:19 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on busoni.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 98; hammy, 151; neutral, 140; spammy,
	0. spammytokens: hammytokens:0.000-+--HX-Debian:DAK,
	0.000-+--H*RU:128.148.34.103, 0.000-+--H*rp:D*ftp-master.debian.org,
	0.000-+--HX-DAK:process-upload, 0.000-+--UD:diff.gz
X-Spam-Status: No, score=-12.8 required=4.0 tests=AWL,BAYES_00,FROMDEVELOPER,
	FVGT_m_MULTI_ODD,HAS_BUG_NUMBER,IMPRONONCABLE_2,MURPHY_DRUGS_REL8,
	MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2,PGPSIGNATURE autolearn=ham
	version=3.2.5-bugs.debian.org_2005_01_02
Return-path: <envelope at ftp-master.debian.org>
Received: from ries.debian.org ([128.148.34.103])
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=ries.debian.org,EMAIL=hostmaster at ries.debian.org (verified)
	by busoni.debian.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69)
	(envelope-from <envelope at ftp-master.debian.org>)
	id 1O4XiB-00019F-FQ
	for 578481-close at bugs.debian.org; Wed, 21 Apr 2010 11:03:19 +0000
Received: from dak by ries.debian.org with local (Exim 4.69)
	(envelope-from <envelope at ftp-master.debian.org>)
	id 1O4Xi9-0006Vr-Th; Wed, 21 Apr 2010 11:03:17 +0000
From: Damyan Ivanov <dmn at debian.org>
To: 578481-close at bugs.debian.org
X-DAK: dak process-upload
X-Debian: DAK
X-Debian-Package: libapache2-mod-perl2
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Subject: Bug#578481: fixed in libapache2-mod-perl2 2.0.4-7
Message-Id: <E1O4Xi9-0006Vr-Th at ries.debian.org>
Sender: Archive Administrator <dak at ries.debian.org>
Date: Wed, 21 Apr 2010 11:03:17 +0000

Source: libapache2-mod-perl2
Source-Version: 2.0.4-7

We believe that the bug you reported is fixed in the latest version of
libapache2-mod-perl2, which is due to be installed in the Debian FTP archive:

libapache2-mod-perl2-dev_2.0.4-7_all.deb
  to main/liba/libapache2-mod-perl2/libapache2-mod-perl2-dev_2.0.4-7_all.deb
libapache2-mod-perl2-doc_2.0.4-7_all.deb
  to main/liba/libapache2-mod-perl2/libapache2-mod-perl2-doc_2.0.4-7_all.deb
libapache2-mod-perl2_2.0.4-7.diff.gz
  to main/liba/libapache2-mod-perl2/libapache2-mod-perl2_2.0.4-7.diff.gz
libapache2-mod-perl2_2.0.4-7.dsc
  to main/liba/libapache2-mod-perl2/libapache2-mod-perl2_2.0.4-7.dsc
libapache2-mod-perl2_2.0.4-7_amd64.deb
  to main/liba/libapache2-mod-perl2/libapache2-mod-perl2_2.0.4-7_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 578481 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Damyan Ivanov <dmn at debian.org> (supplier of updated libapache2-mod-perl2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 21 Apr 2010 12:48:11 +0300
Source: libapache2-mod-perl2
Binary: libapache2-mod-perl2 libapache2-mod-perl2-dev libapache2-mod-perl2-doc
Architecture: source all amd64
Version: 2.0.4-7
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
Changed-By: Damyan Ivanov <dmn at debian.org>
Description: 
 libapache2-mod-perl2 - Integration of perl with the Apache2 web server
 libapache2-mod-perl2-dev - Integration of perl with the Apache2 web server - development fil
 libapache2-mod-perl2-doc - Integration of perl with the Apache2 web server - documentation
Closes: 578481
Changes: 
 libapache2-mod-perl2 (2.0.4-7) unstable; urgency=low
 .
   * change source Section to 'httpd'
   * add a patch from Niko Tyni avoiding two warnings about use of uninitialized
     values, which break tests under Perl 5.12. (Closes: #578481)
   * add a patch fixinf spelling errors in POD and other documentation
   * add a patch fixinng POD errors
   * add a patch fixing bad manpage whatis name
   * Standards-Version: 3.8.4
     + support 'nockeck' in DEB_BUILD_OPTIONS as per Policy 3.8.1
   * describe all patches
Checksums-Sha1: 
 6d18d09e5b73763c2173969da749211e83c8adeb 2477 libapache2-mod-perl2_2.0.4-7.dsc
 d475a7e4bf93d4a1008d8aaa29ecdcb5ccd80f5c 16362 libapache2-mod-perl2_2.0.4-7.diff.gz
 1456d57961ec863d510389a1b1813b05d83b9429 79740 libapache2-mod-perl2-dev_2.0.4-7_all.deb
 0046659b0abe80e88cc86ce578e36e91479aba81 3130740 libapache2-mod-perl2-doc_2.0.4-7_all.deb
 957b676d38535ac12d4b7a8f443e27bcc2b745db 1110888 libapache2-mod-perl2_2.0.4-7_amd64.deb
Checksums-Sha256: 
 9c90a862cbd05335ca0d3e3df3e26183853abebac700ce3e65fdb3b5e7b312e8 2477 libapache2-mod-perl2_2.0.4-7.dsc
 68cc179099b00c46b64f1c451b568c3557db4a661ce58b4976a9f472fe75c965 16362 libapache2-mod-perl2_2.0.4-7.diff.gz
 d882850c0b1593a014911f25eac0c05866184a9c46b32416a82eb3c8893d3912 79740 libapache2-mod-perl2-dev_2.0.4-7_all.deb
 c5a0d9dc1ce46e5ed0c865dd31c8cc4ebd1665d6e7edfc10ba034c6d40d4ce32 3130740 libapache2-mod-perl2-doc_2.0.4-7_all.deb
 8ee0d3d88a6f6f5146653bd1d6ac4e76d27beae8bd25878c63fe9ea6582c4e4b 1110888 libapache2-mod-perl2_2.0.4-7_amd64.deb
Files: 
 9e65b292c094feb4f659aaf383b6f01d 2477 httpd optional libapache2-mod-perl2_2.0.4-7.dsc
 253232f204248adde824df22b2678319 16362 httpd optional libapache2-mod-perl2_2.0.4-7.diff.gz
 f9d9a066d4dc1d5e1638d81a6a8b5e9c 79740 libdevel optional libapache2-mod-perl2-dev_2.0.4-7_all.deb
 7c2f319e3e5990b64ccbe972e6fe1ff6 3130740 doc optional libapache2-mod-perl2-doc_2.0.4-7_all.deb
 4c504f51ab320f3f8c5989f0a6d8ce77 1110888 httpd optional libapache2-mod-perl2_2.0.4-7_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLztfrAAoJEOQbTFV/DYC+C1gP/12jFqaOOxS43+KMLgdGkBzJ
Emk5VOanoi00T417mQzDaASeyB//wX5mXfcVDcb7iblprjURwwNisQPysGeg1k3Q
Wn2IoOWY2HK3Gvm4K/wMYRRzbmMGJWsA9sQ4GIm4t70Q5vQa7YOqULEMQfpO6Qvb
lw4ILxIUi1GIfNekmoWz1K5t9du3Mxr6QT+CcgkRBulrNIDMGWmxHPIWbza+VvZM
Fty2Lh5XgN3kV1vjOaN5Wv1WxuWsHQf3gTF1/lImLx+oN2DyxX/1FdKBU3PY1Tda
U4VXYI9Ea/vNCefSWQWnIhqwcqPf22zod5IxDMxEsn2liKSg/k2/OHnyRArgse0T
ZC6ZZAu5c9KUgwVNzjZCP3Kg3RBLkCHN/CjzKPNSqulJ+ymIjHLx5UDZC3j9sxjE
pu73JXzzJKXZpyN+Z/as114EkxqkWORGcdUsLvfXyjzK53W27Ut7uQ3AtfsmIlk0
GoMhwaD1qtr8dTnNUfmCtS0nG485fXES1RWebmn3cAHLxFXxfjvHEke5kHfvKuE5
2mLJBvnCvQEFCR2HItc3n1ncsBu1NzHgnqCLFdBqqLhsyaTKlpVGuysfgmRGAJsz
fW2ddiJtMLIh9N5gAit4XEgLg5Ymh5biYuJeLVM8A7ghEatYLMtKOEQAnAIjtHUf
t531ckwWo5FpXKu72unr
=TM57
-----END PGP SIGNATURE-----



------------=_1271847966-6066-0--

