Bug#558272: Date::Calc::Decode_Month(): argument is not a string
Ansgar Burchardt
ansgar at 43-1.org
Thu Aug 26 15:53:54 UTC 2010
Niko Tyni <ntyni at debian.org> writes:
> On Thu, Aug 26, 2010 at 05:47:53PM +0900, Ansgar Burchardt wrote:
>
>> I prepared a patch for this issue. It passes the test suite and also
>> the code snippets that failed before. I am not very familiar with XS,
>> so any comments are welcome.
>
>> [1] <http://svn.debian.org/viewsvn/pkg-perl/branches/unstable/libdate-calc-perl/debian/patches/SvPV.patch?revision=62052&view=markup>
>
> I think even the SvROK() is overly defensive. Consider the attached
> amended test file, which has an additional regression test from the
> lenny version.
>
> Of course, it would be nice to get the upstream opinion.
True, I forgot about overload here. I updated the patch accordingly and
also amended the test as well.
The patch is now also forwarded upstream [2] (very slightly modified to
apply to Date::Calc::XS).
Regards,
Ansgar
[2] <https://rt.cpan.org/Public/Bug/Display.html?id=60233#txn-822819>
More information about the pkg-perl-maintainers
mailing list