Bug#568607: libogg-vorbis-perl: dup syscall yields fd leak

Vincent Lefevre vincent at vinc17.net
Sun Feb 7 01:09:09 UTC 2010


tags 568607 patch
thanks

Actually, $ogg->clear solves the problem. But then, the clear method
should be called when the object is destroyed. I've attached a patch.
This patch calls ov_clear directly, but this seems to work even when
ov_clear has already been called (doing $ogg->clear twice is allowed
and does the same thing anyway).

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)
-------------- next part --------------
--- libvorbis-perl-0.05.ds1.orig/Vorbis.xs	2003-08-13 14:16:29.000000000 +0000
+++ libvorbis-perl-0.05.ds1/Vorbis.xs	2010-02-07 00:57:36.000000000 +0000
@@ -49,6 +49,7 @@
 DESTROY(self)
 	OggVorbis_File *self
     CODE:
+	ov_clear(self);
 	safefree(self);
 
 int


More information about the pkg-perl-maintainers mailing list