Bug#564772: libjavascript-perl: Segfaults with wpad extraction code

[Niko Tyni]

close 564772 1.12-1
tag 564772 patch lenny
thanks

On Tue, Jan 12, 2010 at 11:11:10AM +0200, Niko Tyni wrote:

> I haven't really investigated the segfault: given that there's an error
> indicator before it happens and that it's fixed in sid, I don't think
> it's worth the effort trying to fix it in lenny. YMMV of course.

Heh, turns out I couldn't resist.

Here's the smallest test case I could easily come up with that shows
errors with 'valgrind debugperl t.pl':

use JavaScript;

for (1..4) { 
    my $r = JavaScript::Runtime->new;
    my $c = $r->create_context;
    $c->eval("function a () { b(); }");
    die $@ if $@;
    $c->call("a");
    warn("$_: $@");
}
__END__

The errors are gone with upstream version 1.10; the attached patch from
 svn://svn.versed.se/public/Perl/modules/JavaScript/trunk
revision 931 seems to be the one that fixed it.

+    - Fixed a couple of problems that cause contexts no to be destroyed when supposed to

The Changes chunk doesn't apply to 1.08 but the rest does, and the
new package seems to work correctly and doesn't crash with the
'wpadextract' code anymore.

Therefore closing at 1.12-1, which was the first fixed version in Debian,
and tagging. 

I'm not going to prepare a Lenny update but if somebody else wants to,
be my guest.

Cheers,
-- 
Niko Tyni   ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 564772.patch
Type: text/x-diff
Size: 2741 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20100112/6ea1bd2f/attachment.patch>