Bug#582672: libmail-mbox-messageparser-perl: warnings with Perl 5.12, breaks grepmail

[Ansgar Burchardt]

clone 582672 -1
reassign -1 grepmail
thanks

Niko Tyni <ntyni at debian.org> writes:

> Perl 5.12.1 (currently in experimental) gives a new warning
> on every use of this module:
>
>  $ perl -w -MMail::Mbox::MessageParser -e 1
>  Name "Mail::Mbox::MessageParser::OLDSTDERR" used only once: possible typo at /usr/share/perl5/Mail/Mbox/MessageParser.pm line 297.

This looks like a false positive: OLDSTDERR is used more than once, but
the second use is hidden:

  open STDERR,">&OLDSTDERR" or die "Can't restore STDERR: $!\n";

Changing that to

  open STDERR, ">&", \*OLDSTDERR or die ...

should remove the warning.

> Setting the severity to "important" because this breaks the grepmail
> test suite, making the package fail to build from source.

grepmail uses -w in the hashbang which enables warnings for all loaded
modules.  It should just "use warnings;" instead as not all CPAN modules
do "use warnings;" themselves and cannot be expected to not produce any
warnings if this pragma is enabled.

Regards,
Ansgar