Bug#587276: dh-make-perl: no Depends: set under --intrusive

[Kevin Ryde]

Package: dh-make-perl
Version: 0.68-1
Severity: normal
File: /usr/share/perl5/Debian/Control/FromCPAN.pm

On an unpacked Image::Pbm 0.03 from cpan, running

    dh-make-perl --intrusive --requiredeps Image-Pbm-0.03

gives debian/control with nothing in the Depends: line, where I hoped
for

    libimage-base-bundle-perl (>= 1.08),
    libimage-pbmlib-perl (>= 1.05)

as per the PREREQ_PM in the Makefile.PL.


Nosing around Debian::Control::FromCPAN discover_dependencies(), I
wonder if there's a misplaced "return" under the intrusive leg, so when
Module::Depends::Intrusive is successful discover_dependencies() doesn't
go on to its normal modules to debs code.

Perhaps the return belongs only under the "If you understand the
security implications" bit, ie. when there was an error from the plain
attempt and it's not going to try intrusive.

(I also wonder earlier under the leg where the intrusive is attempted
and gives an error, if the "return" there belongs outside $verbose
... but I say that without trying to provoke it.)


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-1-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages dh-make-perl depends on:
ii  debhelper                     7.9.1      helper programs for debian/rules
ii  dpkg-dev                      1.15.7.2   Debian package development tools
ii  fakeroot                      1.14.4-1   Gives a fake root environment
ii  libapt-pkg-perl               0.1.24     Perl interface to libapt-pkg
ii  libarray-unique-perl          0.08-1     Tie-able array that allows only un
ii  libclass-accessor-perl        0.34-1     Perl module that automatically gen
ii  libdpkg-perl                  1.15.7.2   Dpkg perl modules
ii  libemail-date-format-perl     1.002-1    Module to generate RFC-2822-valid 
ii  liblist-moreutils-perl        0.25-02-1  Provide the stuff missing in List:
ii  libmodule-corelist-perl       2.35-1     module to determine modules shippe
ii  libmodule-depends-perl        0.14-3     identify the dependencies of a dis
ii  libparse-debcontrol-perl      2.005-2    Easy OO parsing of Debian control-
ii  libparse-debianchangelog-perl 1.1.1-2    parse Debian changelogs and output
ii  libtie-ixhash-perl            1.21-2     ordered associative arrays for Per
ii  libwww-mechanize-perl         1.62-1     module to automate interaction wit
ii  libyaml-perl                  0.71-1     YAML Ain't Markup Language
ii  make                          3.81-8     An utility for Directing compilati
ii  perl                          5.10.1-13  Larry Wall's Practical Extraction 
ii  perl-modules [libmodule-corel 5.10.1-13  Core Perl modules

Versions of packages dh-make-perl recommends:
ii  apt-file                      2.4.0      search for files within Debian pac

dh-make-perl suggests no packages.

-- no debconf information