libmodule-pluggableperl patch problem

[gregor herrmann]

On Thu, 04 Mar 2010 13:36:30 +0000, Mark Fowler wrote:

> Hello,

Hi Mark,

thanks for your mail.

I'm full-quoting it and CC'ing the group mail address and bricas,
who presumably prepared the patch.
 
> I was looking at http://svn.debian.org/viewsvn/pkg-perl?view=rev&revision=33289
> (I'm attempting to role my own 5.11.5 package, and I've been hitting
> the some problems, so I came to see what you did)

:)
 
> Isn't removing the Bar.pm~ file from the MANIFEST the wrong thing to
> do here?  It's not included by Simon Wistow by mistake in the
> distribution and MANIFEST - it's part of the test suite and is used to
> check that Module::Pluggable doesn't pick up Bar.pm~ files when it's
> searching @INC, and without that file the test suite isn't checking
> that anymore.
> 
> The error Makefile.PL is giving about a missing Bar.pm~ is legitimate
> - the clean section of rules deletes the file that's shipped with the
> distribution.

I see, thanks for pointing this out.

Without having looked closer, we probably hit debhelper's (or
dh_clean's to be exact) magic here, which cleans up files that look
like backups or editor artifacts.

If Bar.pm~ is intended, then something like (untested)

override_dh_clean:
    dh_clean -XBar.pm~

might do the trick (in the new dh7 style).

Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG Key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    Phasers locked on target, Captain.