Bug#615510: nama: FTBFS, failing tests

[gregor herrmann]

retitle 615510: nama: FTBFS with new libyaml-tiny-perl
tag 615510 + confirmed
thanks

On Sun, 27 Feb 2011 01:19:58 +0100, Salvatore Bonaccorso wrote:

> > Can't exec "pgrep": No such file or directory at /build/salvi-nama_1.064-6-amd64-VGcSs_/nama-1.064/blib/lib/Audio/Nama.pm line 1677.
> > Can't exec "ps": No such file or directory at /build/salvi-nama_1.064-6-amd64-VGcSs_/nama-1.064/blib/lib/Audio/Nama.pm line 1678.

That part is easy: add procps.

> > #   Failed test 'use Audio::Nama;'
> > #   at t/12_nama.t line 9.
> > #     Tried to use 'Audio::Nama'.
> > #     Error:  Can't use an undefined value as a HASH reference at /build/salvi-nama_1.064-6-amd64-VGcSs_/nama-1.064/blib/lib/Audio/Nama.pm line 615, <DATA> line 2390.

But then it still FBTFS. With some debugging output I end up with:

# prove --blib --verbose t/12_nama.t
t/12_nama.t .. 
YAML::Tiny read error: YAML::Tiny found illegal characters in plain scalar: '<start> <end> (start, end: mark names, mark indices, decimal seconds)'
not ok 1 - use Audio::Nama;

#   Failed test 'use Audio::Nama;'
#   at t/12_nama.t line 9.
#     Tried to use 'Audio::Nama'.
#     Error:  Can't use an undefined value as a HASH reference at /tmp/buildd/nama-1.064/blib/lib/Audio/Nama.pm line 615, <DATA> line 2390.
# Compilation failed in require at (eval 6) line 2, <DATA> line 2390.
# BEGIN failed--compilation aborted at (eval 6) line 2, <DATA> line 2390.


Looking at YAML-Tiny's Changes I see:

1.45_01 Tue 7 Dec 2010
        - Added checks for some characters that are illegal or reserved
          in plain scalars (INGY)

And the change in the code seems to be:

-       return $string unless $string =~ /^[>|]/;
+       if ( $string !~ /^[>|]/ ) {
+               if (
+                       $string =~ /^(?:-(?:\s|$)|[\@\%\`])/
+                       or
+                       $string =~ /:(?:\s|$)/
+               ) {
+                       die \"YAML::Tiny found illegal characters in plain scalar: '$string'";
+               }
+               $string =~ s/\s+#.*\z//;
+               return $string;
+       }


Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Pink Floyd: Us And Them
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20110227/86b8dc63/attachment-0001.pgp>