Bug#636651: mod_perl2 and Perl 5.14 with uselargefiles on 32-bit architectures (was: Early core dump)

[Dominic Hargreaves]

On Sun, Nov 13, 2011 at 02:17:48PM +0200, Niko Tyni wrote:
> On Sat, Nov 12, 2011 at 09:29:50PM +0000, Dominic Hargreaves wrote:
> 
> > Hi Niko, and pkg-perl,
> > 
> > Since this the only significant blocker now, I'd like to try and get it
> > wrapped up one way or another. I've built libapache2-mod-perl2 with the
> > attached patch today, and run request-tracker4 with mod_perl happily on
> > it, with perl 5.12 and 5.14. 
> 
> I assume this is on i386?

Yup.

> > If I understand things correctly from the
> > above, you think this should be okay, for Debian if not for upstream (it
> > wasn't obvious to me) but wanted additional verification. Since we haven't
> > had any response to that specific point, either negative or positive, I
> > think it's probably time to give it a try - it's unlikely to be worse
> > than not having libapache2-mod-perl2 installable.
> 
> Yes, I agree it's definitely  worth trying. Many thanks for pushing this.
> 
> I'm not sure if it's cleaner to patch away all the related functions
> (strip_lfs() and has_large_files_conflict()) like you do, or just stop
> calling them. Your approach is probably safer as it makes sure nobody
> else uses them. You might want to stick in a comment pointing to the
> Debian bug in the patched versions, though, so that anybody reading
> through the code in the binary package is aware that we're patching it.

Yeah, good point.

> A note about this on the upstream list would also be appropriate IMO.
> The discussion there didn't really get far but I think other distributions
> are hitting this too. (What's Fedora doing BTW? I think they're shipping
> with 5.14 now.)

A quick look at
<http://download.fedora.redhat.com/pub/fedora/linux/releases/16/Fedora/source/SRPMS/mod_perl-2.0.5-5.fc16.src.rpm>

suggests that they aren't patching for this issue; and having spun up a
FC16 VM, the reason becomes clear; they aren't compiling with
-D_FILE_OFFSET_BITS=64.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)