Bug#668084: dh-make-perl.conf breaks cpan2deb

[gregor herrmann]

tag 668084 + confirmed
thanks

On Sun, 08 Apr 2012 23:39:52 -0400, Brendan Byrd wrote:

> tag 668084 - moreinfo
> found 668084 dh-make-perl/0.75-1
> thanks

Thanks for the additional information!
 
> > - What does the .conf file look like?
> Pretty basic; mostly just a copy from dump-config:

Ok.
 
> > - What was the full command you were running (which CPAN module are you
> >  trying to build)?
> 
> Doesn't matter, though when I try a non-existent one, I get the (more
> helpful) error message I was trying to duplicate before:
> 
> # cpan2deb Blah::FooBar
> WARNING: Neither META.json nor META.yml was found
> Unable to determine dist name, no Build.PL, no Makefile.PL
> Please use --cpan.
> 
> That should be a clue as to what is going on.  For some reason, it
> doesn't think it's actually specifying --cpan, even though the --cpan
> is implied with the cpan2deb command.

Interesting.

With my own (rather minimal) dh-make-perl.conf or without any I get:

% cpan2deb Blah::FooBar
CPAN: File::HomeDir loaded ok (v0.99)
Going to read '/home/gregoa/.cpan/Metadata'
  Database was generated on Mon, 09 Apr 2012 11:51:03 GMT
Can't find 'Blah::FooBar' module or distribution on CPAN

And I can reproduce your error with your conf and the one from
dump-config:

% cpan2deb Blah::FooBar
WARNING: Neither META.json nor META.yml was found
Unable to determine dist name, no Build.PL, no Makefile.PL
Please use --cpan.
 
> > - Is this reproducible with the dh-make-perl version from unstable?
> Yep.

Indeed :)
 

Ok, after digging through the code, it seems that that cpan option
first gets set (when called as cpan2deb or with --cpan) in
parse_command_line_options and then thrown out again in
parse_config_file, if the config file contains "cpan: ~".

So the quick workaround is to remove "cpan: ~" from
~/.dh-make-perl/dh-make-perl.conf.

On the code side, marking cpan as explicitely_set when called as
cpan2deb seems to work too.

Committed to git, reviews welcome.


Cheers,
gregor

 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bruce Springsteen: Born In The U.s.a.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120409/c862b631/attachment.pgp>