Bug#661545: Patch for 661545

[Salvatore Bonaccorso]

Control: tags -1 - patch

Hi Brian

On Thu, Dec 06, 2012 at 01:46:18AM +0000, brian m. carlson wrote:
> tags 661545 + patch
> kthxbye
> 
> A patch is included to fix the format string issue, minor as it might
> be.
> 
> -- 
> brian m. carlson / brian with sandals: Houston, Texas, US
> +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
> OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

> diff -urN libproc-processtable-perl-0.45.orig/ProcessTable.xs libproc-processtable-perl-0.45/ProcessTable.xs
> --- libproc-processtable-perl-0.45.orig/ProcessTable.xs	2012-12-06 01:37:15.548659798 +0000
> +++ libproc-processtable-perl-0.45/ProcessTable.xs	2012-12-06 01:38:30.960137369 +0000
> @@ -388,5 +388,5 @@
>       char* error;
>  
>       if( (error = OS_initialize()) != NULL ){
> -       croak(error);
> +       croak("%s", error);
>       }

Thanks for you patch and looking at #661545. AFAICS there is still
more work needed to make the package build with hardening flags
enabled:

----cut---------cut---------cut---------cut---------cut---------cut-----
make[1]: Entering directory `/tmp/buildd/libproc-processtable-perl-0.46'
cp ProcessTable.pm blib/lib/Proc/ProcessTable.pm
cp Killall.pm blib/lib/Proc/Killall.pm
cp example.pl blib/lib/Proc/example.pl
cp Killfam.pm blib/lib/Proc/Killfam.pm
make[2]: Entering directory `/tmp/buildd/libproc-processtable-perl-0.46/Process'
cp Process.pm ../blib/lib/Proc/ProcessTable/Process.pm
AutoSplitting ../blib/lib/Proc/ProcessTable/Process.pm (../blib/lib/auto/Proc/ProcessTable/Process)
Manifying ../blib/man3/Proc::ProcessTable::Process.3pm
make[2]: Leaving directory `/tmp/buildd/libproc-processtable-perl-0.46/Process'
/usr/bin/perl /usr/share/perl/5.14/ExtUtils/xsubpp  -typemap /usr/share/perl/5.14/ExtUtils/typemap  ProcessTable.xs > ProcessTable.xsc && mv ProcessTable.xsc ProcessTable.c
cc -c   -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fstack-protector -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2   -DVERSION=\"0.46\" -DXS_VERSION=\"0.46\" -fPIC "-I/usr/lib/perl/5.14/CORE"   ProcessTable.c
cc -c   -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fstack-protector -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2   -DVERSION=\"0.46\" -DXS_VERSION=\"0.46\" -fPIC "-I/usr/lib/perl/5.14/CORE"   OS.c
OS.c: In function 'eval_link':
OS.c:400:5: error: format not a string literal and no format arguments [-Werror=format-security]
OS.c: In function 'OS_get_table':
OS.c:633:9: error: format not a string literal and no format arguments [-Werror=format-security]
OS.c:703:9: warning: passing argument 2 of 'bless_into_proc' from incompatible pointer type [enabled by default]
In file included from OS.c:21:0:
os/Linux.h:4:6: note: expected 'char **' but argument is of type 'const char * const*'
cc1: some warnings being treated as errors
make[1]: *** [OS.o] Error 1
make[1]: Leaving directory `/tmp/buildd/libproc-processtable-perl-0.46'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
----cut---------cut---------cut---------cut---------cut---------cut-----

Regards,
Salvatore
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20121206/40a3b6b7/attachment-0001.pgp>