Bug#654899: libarchive-zip-perl: jh_manifest from javahelper creates corrupt archives (jars)

[gregor herrmann]

On Tue, 21 Feb 2012 12:50:25 +0200, Niko Tyni wrote:

> The patches aren't actually applied in 1.30-5 because
> debian/patches/series wasn't updated. I'm really surprised nobody has
> noticed this before.

Ouch! How embarrassing; I'm really sorry for this silly mistake.

> BTW, the embedded binary file in the second patch is in Git format,
> which probably won't work as-is in debian/patches. I guess some
> dpkg 3.0 (quilt) magic might be needed for that.

Thanks for the heads-up, indeed quilt happily applies the patch and
silently ignores the binary part. (Obviously the test that tries to
use it fails later.)

Extracting the file (with "git apply") and
% echo t/data/jar.zip > debian/source/include-binaries
works.

But then the test fails with:

#   Failed test 'output zip isn't corrupted'
#   at t/17_bug_73797.t line 26.
#          got: '-1'
#     expected: '0'
# Looks like you failed 1 test of 4.
t/17_bug_73797.t .............. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests 

*Headscratch*
*Debug*

Aha, seems like tests (not only in this file) are skipped if there is
no unzip program around.

Next step: now testZip() tries to run `unzip -t testin.zip' (instead
of testout.zip). Plain test output:

warning: unzip -t  doesn't seem to work, may skip some tests at t/common.pl line 200.
Label not found for "last SKIP" at /usr/share/perl/5.14/Test/More.pm line 1256.
# Looks like your test exited with 9 just after 4.
t/17_bug_73797.t .............. 
Dubious, test returned 9 (wstat 2304, 0x900)
All 4 subtests passed 
    (less 1 skipped subtest: 3 okay)



Ok, after more head-scratching I'm giving up, this t/common.pl is too
confusing for me with its various BEGIN {} blocks :/

I'm committing and pushing what I have so far (including another
patch to make upstream's clean target actually work ...)


Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Cat Stevens: Trouble
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120221/711b18e0/attachment.pgp>