Bug#654899: libarchive-zip-perl: jh_manifest from javahelper creates corrupt archives (jars)

[Niko Tyni]

tag 654899 patch
thanks

On Tue, Jan 10, 2012 at 09:56:31PM +0200, Niko Tyni wrote:
> On Mon, Jan 09, 2012 at 04:19:29PM +0200, Niko Tyni wrote:
>  
> > OK, I see it now. Still no idea why I couldn't get it to happen with the
> > hand made .jar, but when testing with the terraintool source I missed
> > the (now obvious) fact that jh_manifest was operating on the copy in
> > debian/terraintool/usr/share/...
> 
> Status update: it happens with jar/zip files created by the jar binary
> from OpenJDK. Just reading a zip and writing it out triggers it without
> having to add or delete any members.

>   META-INF/:  ucsize 0 <> csize 2 for STORED entry

> Will dive into the Archive::Zip code next, and glare at 'zipinfo -v' output.

Blah, what a waste of time. I fixed the bug, checked if upstream
has a git repository or if I'll have to uuencode the test jar file,
and noticed there's an svn repository that already has the bug fixed
in a different way.

The bug is with deflated empty files, which grow with the deflation.
The upstream version stores them, my version keeps them deflated.
I expect either of them should do.

See 
 [rt.cpan.org #68446] 
 r14788 @ http://svn.ali.as/cpan/trunk/Archive-Zip/
and the attached patches.

I'll forward the patches to the upstream ticket anyway, at least the
test case should be useful.
-- 
Niko Tyni   ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-the-embedded-File-Which-which-work-in-BEGIN-blo.patch
Type: text/x-diff
Size: 1178 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120111/0f1fa004/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-TODO-test-for-rt.cpan.org-73797-deflated-empty-file-.patch
Type: text/x-diff
Size: 2377 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120111/0f1fa004/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-for-rt.cpan.org-73797-deflated-empty-file-direct.patch
Type: text/x-diff
Size: 1637 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120111/0f1fa004/attachment-0005.patch>
-------------- next part --------------
begin 644 jar.zip
M4$L#!!0`"``(`!IR*D`````````````````)``0`345402U)3D8O_LH```,`
M4$L'"``````"`````````%!+`P04``@`"``:<BI`````````````````%```
M`$U%5$$M24Y&+TU!3DE&15-4+DU&\TW,RTQ++2[1#4LM*L[,S[-2,-0SX.5R
M+DI-+$E-T76J!`F8Z1G$&YDH:`27YBGX9B87Y1=7%I>DYA8K>.8EZVGR<O%R
M`0!02P<(;SF2!4<```!'````4$L#!`H``````!%R*D`````````````````#
M````=&<O4$L!`A0`%``(``@`&G(J0``````"``````````D`!```````````
M`````````$U%5$$M24Y&+_[*``!02P$"%``4``@`"``:<BI`;SF2!4<```!'
M````%``````````````````]````345402U)3D8O34%.249%4U0N34902P$"
M"@`*```````1<BI``````````````````P````````````````#&````=&<O
64$L%!@`````#``,`K@```.<`````````
`
end