Bug#677702: libdevice-cdio-perl: FTBFS with libcdio 0.83

[Damyan Ivanov]

-=| gregor herrmann, 16.06.2012 15:03:30 +0200 |=-
> On Sat, 16 Jun 2012 13:32:13 +0200, gregor herrmann wrote:
> 
> > On Sat, 16 Jun 2012 12:08:55 +0200, Julien Cristau wrote:
> > > Justification: fails to build from source (but built successfully in the past)
> > > See https://buildd.debian.org/status/package.php?p=libdevice-cdio-perl
> > 
> > Thanks.
> > We already have a newer version in git that was waiting for a more
> > recent libcdio-dev; let's hope this works better :)
> 
> Ok, one and a half hour later the new version in git builds (inside
> and outside a chroot); reviews from someone else in the perl group
> would be appreciated, and there's still a patch where I'm not sure if
> it's needed. 

For those watching at home, the patch hunk in question is:

--- a/swig/perliso9660.swg
+++ b/swig/perliso9660.swg
@@ -42,7 +42,7 @@
 %constant long int RECORD               = ISO_RECORD;
 
 /* When version 0.77 comes out, require it and fix this fix this. */
-#if 0
+#if LIBCDIO_VERSION_NUM >= 77
 %constant long int PROTECTION           = ISO_PROTECTION;
 #else 
 %constant long int PROTECTION           = 16;

The interesting part is that Debian/squeeze has libcdio 0.81.

Gregor, what is your doubt about? To me the current patch seems slightly 
better than replacing "#if 0" with "#if 1" or using ISO_PROTECTION 
unconditionally, as it is both instructive as of why the #if is there 
and still allows building with older libcdio (in case there is some 
value in this).

Dropping the patch would be bad, as it may introduce incompatibility 
with libcdio, I guess.


IOW, the patch seems fine to me as it is. So fine, in fact, that 
I uploaded the package :)

Cheers!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120622/82800a50/attachment.pgp>