Bug#665221: Dancer-Plugin-Database bug + testcase

[David Precious]

On Thu, 28 Jun 2012 21:24:03 +0200
intrigeri <intrigeri at boum.org> wrote:

> David Precious wrote (28 Jun 2012 18:42:19 GMT) :
> > I'm looking for a decent safe fix now; if I find one, I'll get a new
> > release out tonight, hopefully that's not too late.
> 
> Tonight would be perfect.
> Thanks for working on it.
> 
> > If I do, I'll provide a link to the commit(s) which fix the issue,
> > in case you need to backport only the changes.
> 
> Emailing me and 665221 at bugs.debian.org would be perfect :)

Version 1.82 just headed to CPAN, containing a simple fix for this
issue.

The actual fix was:

https://github.com/bigpresh/Dancer-Plugin-Database/commit/85e8cd06ff

When caching a handle, if we were given a hashref of settings, we cache
a reference to that hashref, too - so the original hashref of settings
doesn't go out of scope while the handle is still cached.

This simple change should do the job!

Many thanks for reporting this issue to me and prompting me for a fix
before Wheezy :)


-- 
David Precious ("bigpresh") <davidp at preshweb.co.uk>
http://www.preshweb.co.uk/     www.preshweb.co.uk/twitter
www.preshweb.co.uk/linkedin    www.preshweb.co.uk/facebook
www.preshweb.co.uk/cpan        www.preshweb.co.uk/github