Bug#688069: liblocale-subcountry-perl: Version checks fail ("our $VERSION" moved before "package Locale::SubCountry")

[gregor herrmann]

On Tue, 18 Sep 2012 13:54:35 -0700, Ivan Kohler wrote:

> $ perl -e 'use Locale::SubCountry 54'
> Locale::SubCountry does not define $Locale::SubCountry::VERSION--version check failed at -e line 1.
> 
> Sometime after version 1.50, "our $VERSION = 1.xx" was moved to the top of
> the code, above any "package" declaration.  It is therefore not declaring
> $Locale::SubCountry::VERSION, and previously-working version checks like
> "use Locale::SubCountry 1.42" now throw a fatal error.
> 
> The patch below adds a "package Locale::SubCountry" to the beginning of the
> code.  This seems like typical / best practice for modules, to avoid any
> symbol exports from the intial "use" statements from polluting the main::
> namespace.

Are you going to upload the fixed package? Or should someone else go
ahead?
 

Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Ben Weaver: Boxcars
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20121024/3d3bc574/attachment-0001.pgp>