Bug#686750: libmojolicious-perl: Websocket _xor_mask clobbers $_

[Dominique Dumont]

Package: libmojolicious-perl
Version: 2.98+dfsg-1
Severity: important
Tags: upstream patch

Dear Maintainer,

WHen calling send on a webcsocket with masked mode on, the function
_xor_mask overwrites $_ (without a local statement).

This works fine most of the time, but fail if $_ is an alias to a read-only
value .

E.g. this fails:

$ws->send('bar') for (qw/foo/) ;

with :

[error] Event "read" failed: Modification of a read-only value attempted at /usr/share/perl5/Mojo/Transaction/WebSocket.pm line 301.

This issue has been fixed upstream:

https://github.com/kraih/mojo/commit/2d31456be85b8cc5b71d08d8ae3c5ee463e4ec8c

I'll apply this fix to our mojolicious

ALl the best

*** Please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these lines ***


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libmojolicious-perl depends on:
ii  libjs-jquery  1.7.2+debian-2.1
ii  perl          5.14.2-12

Versions of packages libmojolicious-perl recommends:
ii  libio-socket-inet6-perl      2.69-2
ii  libio-socket-ssl-perl        1.76-1
pn  libmojo-server-fastcgi-perl  <none>

libmojolicious-perl suggests no packages.

-- no debconf information